Remove unnecessary recursive locking from Http2Stream.Complete#36030
Merged
stephentoub merged 1 commit intodotnet:masterfrom May 8, 2020
Merged
Remove unnecessary recursive locking from Http2Stream.Complete#36030stephentoub merged 1 commit intodotnet:masterfrom
stephentoub merged 1 commit intodotnet:masterfrom
Conversation
We just asserted we're holding the lock. We don't need to take it again.
|
Tagging subscribers to this area: @dotnet/ncl |
karelz
approved these changes
May 7, 2020
wfurt
approved these changes
May 8, 2020
Member
wfurt
left a comment
There was a problem hiding this comment.
LGTM.
I guess Debug.Assert() is sufficient to catch code changes, right?
Member
Author
Yes. And the stuff outside of the lock in this function actually needs to be inside it, so it's necessary that callers lock. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We just asserted we're holding the lock. We don't need to take it again.
cc: @scalablecory