Compile methods in canon form only #36011
Merged
davidwrighton merged 2 commits intodotnet:masterfrom May 8, 2020
Merged
Conversation
- The previous logic would compile methods that were not in canonical form - These methods would never be used by the runtime, and contributed 70MB to a 170MB composite image
Member
Author
|
@dotnet/crossgen-contrib |
trylek
approved these changes
May 7, 2020
Member
trylek
left a comment
There was a problem hiding this comment.
Wow, awesome improvement, thanks David!
Member
|
Does it mean the SDK size will be significantly smaller? (and |
Member
Author
|
@EgorBo, this is an improvement to crossgen2, which is expected to replace crossgen in the future. So, this isn't expected to have an impact on size in the .NET 5 timeframe, as we're not using this tool for any customer scenarios yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also a small fix to an assertion so that debug builds work well