Skip to content

Remove unused locals in System.Private.DataContractSerialization#35958

Merged
stephentoub merged 1 commit intodotnet:masterfrom
NikiforovAll:issues/30457/systemprivatedatacontractserialization
May 8, 2020
Merged

Remove unused locals in System.Private.DataContractSerialization#35958
stephentoub merged 1 commit intodotnet:masterfrom
NikiforovAll:issues/30457/systemprivatedatacontractserialization

Conversation

@NikiforovAll
Copy link
Contributor

@NikiforovAll NikiforovAll commented May 7, 2020

Relates to issue #30457

Summary:

5 unused local variables replaced with discard because of side effect; 1 removed assignment 
System\Runtime\Serialization\ReflectionXmlFormatReader.cs(58,20): warning S1481: Remove the unused local variable 'requiredMembers'.
 System\Runtime\Serialization\SchemaExporter.cs(453,50): warning S1481: Remove the unused local variable 'extension'.
 System\Runtime\Serialization\XmlFormatReaderGenerator.cs(122,26): warning S1481: Remove the unused local variable 'isFactoryType'.
 System\Xml\XmlBufferReader.cs(494,20): warning S1481: Remove the unused local variable 'buffer'.
 System\Xml\XmlBufferReader.cs(503,20): warning S1481: Remove the unused local variable 'buffer'.
 System\Xml\XmlBufferReader.cs(847,20): warning S1481: Remove the unused local variable 'buffer'.

@jaredpar jaredpar mentioned this pull request May 7, 2020
Closed
@stephentoub stephentoub merged commit eb7198f into dotnet:master May 8, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees

No one assigned

Labels

area-Serialization

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NikiforovAll @stephentoub @Dotnet-GitSync-Bot