Delete FEATURE_CORRUPTING_EXCEPTIONS#35938
Merged
jkotas merged 5 commits intodotnet:masterfrom May 7, 2020
Merged
Conversation
Ability to catch corrupting exceptions was disabled in .NET Core since early days for security reasons. This is still disabled after this change, but achieved in much simpler way without the full corrupting exceptions machinery.
5c05989 to
0bf8a16
Compare
janvorli
approved these changes
May 7, 2020
Member
janvorli
left a comment
There was a problem hiding this comment.
LGTM modulo the nits. Very nice cleanup, I would not have expected so much stuff to go away.
| STATIC_CONTRACT_GC_TRIGGERS; | ||
| STATIC_CONTRACT_MODE_COOPERATIVE; | ||
|
|
||
| LOG((LF_EH, LL_INFO100, "RealCOMPlusThrow throwing %s\n", |
Member
There was a problem hiding this comment.
I think it would be good to preserve this LOG (move it to the RealCOMPlusThrow)?
Co-authored-by: Jan Vorlicek <janvorli@microsoft.com>
Member
|
What did all this code do that's being removed? Is HandleProcessCorruptedStateExceptionsAttribute meaningful after this PR? |
Member
Author
Member
Alrighty then :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.