Merged
Conversation
added 3 commits
May 1, 2020 00:35
jasonpugsley
reviewed
May 1, 2020
am11
reviewed
May 1, 2020
am11
reviewed
May 1, 2020
| ``` | ||
| After that, FreeBSD build can be started by running | ||
| ``` | ||
| ROOTFS_DIR=$(pwd)/rootfs/freebsd ./build.sh -cross -os FreeBSD |
Member
There was a problem hiding this comment.
Suggested change
| ROOTFS_DIR=$(pwd)/rootfs/freebsd ./build.sh -cross -os FreeBSD | |
| ROOTFS_DIR=$(pwd)/rootfs/freebsd ./build.sh -cross -os FreeBSD -arch x64 |
Member
Author
There was a problem hiding this comment.
Should this be amd64 or x64? I did not add it as it works without it.
Member
There was a problem hiding this comment.
I think x64 is correct. At some point, some scripts had default cross-build set to arm.
am11
reviewed
May 1, 2020
jkotas
reviewed
May 1, 2020
| docker run --rm --volume $(pwd):$(pwd) --workdir $(pwd) --env ROOTFS_DIR=/crossrootfs/x64 -ti mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-cross-freebsd-11-20200430154008-a84b0d2 ./build.sh -cross -FreeBSD | ||
| ``` | ||
|
|
||
| Build using Toolchain Setup |
Member
There was a problem hiding this comment.
These instructions duplicate the docker image setup. Do we really need them?
I would just document the docker steps above, and mention that if somebody needs to build without docker, they can look at the dockerfile to find the current steps for setting up the environment.
jkotas
reviewed
May 1, 2020
jkotas
reviewed
May 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add doc how to build FreeBSD runtime on Linux
native build steps TBD.
cc: @am11