Make corerun exit code more useful#35684
Merged
cshung merged 1 commit intodotnet:masterfrom May 4, 2020
Merged
Conversation
|
Tagging subscribers to this area: @vitek-karas, @swaroop-sridhar |
jkotas
approved these changes
May 1, 2020
Member
|
You may want to do the same thing here: (corerun for Windows and Unix have separate implementations for historic reasons.) |
Member
|
What about writing to console if any? Since presumably exit code here means there's a bug or misconfiguration -- it's not to help write scripts with it -- its a tool intended only for our use, as far as I know. |
stephentoub
approved these changes
May 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case
corerunfailed to initialize theCoreCLR, we should use the failure HR as the process exit code.