Skip to content

Separate registration for global ComWrappers instance for tracker support and marshalling #35681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elinor-fung merged 2 commits into from
May 5, 2020
Merged

Separate registration for global ComWrappers instance for tracker support and marshalling #35681

elinor-fung merged 2 commits into from
May 5, 2020

Conversation

@elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Apr 30, 2020 •
edited
Loading

Keep registered global instance of ComWrappers for reference tracker support separate from global instance for marshalling.

On ComWrappers, replace

public void RegisterAsGlobalInstance();

with two separate methods for registration:

public static void RegisterForTrackerSupport(ComWrappers instance);
public static void RegisterForMarshalling(ComWrappers instance);

Resolves #35530

cc @AaronRobinsonMSFT @jkoritzinsky @jkotas

@Dotnet-GitSync-Bot
Copy link
Collaborator

Dotnet-GitSync-Bot commented Apr 30, 2020

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@elinor-fung elinor-fung force-pushed the comWrappers-globalSplit branch from 80e74a6 to 44cf9b2 Compare April 30, 2020 23:18
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Apr 30, 2020
View reviewed changes
AaronRobinsonMSFT
AaronRobinsonMSFT approved these changes May 1, 2020
View reviewed changes
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 5.0 milestone May 2, 2020
@elinor-fung elinor-fung merged commit e3c7444 into dotnet:master May 5, 2020
@elinor-fung elinor-fung deleted the comWrappers-globalSplit branch May 5, 2020 01:57
@AaronRobinsonMSFT AaronRobinsonMSFT mentioned this pull request May 5, 2020
Open
@jtbrower jtbrower mentioned this pull request Jun 6, 2020
Closed
13 tasks
@jtbrower jtbrower mentioned this pull request Jun 29, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotas jkotas jkotas approved these changes

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

Assignees

No one assigned

Labels

area-Interop-coreclr new-api-needs-documentation

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

ComWrappers API does not provide a mechanism to identify when it is called from old-style APIs

4 participants

@elinor-fung @Dotnet-GitSync-Bot @jkotas @AaronRobinsonMSFT