Skip to content

Use attribute Link syntax for Common files #35436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkotas merged 4 commits into from
Apr 25, 2020
Merged

Use attribute Link syntax for Common files #35436

jkotas merged 4 commits into from
Apr 25, 2020

Conversation

@marcusturewicz
Copy link
Contributor

@marcusturewicz marcusturewicz commented Apr 25, 2020 •
edited
Loading

Fixes #1266

@ghost
Copy link

ghost commented Apr 25, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@marcusturewicz marcusturewicz marked this pull request as draft April 25, 2020 02:49
@jkotas
Copy link
Member

jkotas commented Apr 25, 2020

Also, could you please reformat the existing Link attributes to have the same indentation? (e.g. https://github.com/dotnet/runtime/blob/master/src/libraries/Microsoft.IO.Redist/src/Microsoft.IO.Redist.csproj#L12)

@marcusturewicz marcusturewicz marked this pull request as ready for review April 25, 2020 06:16
jkotas
jkotas approved these changes Apr 25, 2020
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas jkotas merged commit 890fab0 into dotnet:master Apr 25, 2020
@ViktorHofer
Copy link
Member

ViktorHofer commented Apr 25, 2020

Thanks @marcusturewicz :)

@marcusturewicz marcusturewicz deleted the issue-1266 branch April 25, 2020 12:48
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotas jkotas jkotas approved these changes

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@EgorBo EgorBo Awaiting requested review from EgorBo

@jozkee jozkee Awaiting requested review from jozkee

@layomia layomia Awaiting requested review from layomia

@marek-safar marek-safar Awaiting requested review from marek-safar

@steveharter steveharter Awaiting requested review from steveharter

@steveisok steveisok Awaiting requested review from steveisok

@vargaz vargaz Awaiting requested review from vargaz

Assignees

No one assigned

Labels

area-Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<Link>...</Link> vs. Link="..." for Common files

4 participants

@marcusturewicz @jkotas @ViktorHofer @Dotnet-GitSync-Bot