Delete task code that has been moved to the shared framework SDK in Arcade#35405
Delete task code that has been moved to the shared framework SDK in Arcade#35405v-chayan merged 4 commits intodotnet:masterfrom
Conversation
|
Tagging subscribers to this area: @ViktorHofer |
|
The regenerate readme files are also obsolete and can be removed :) |
I didn't find a copy of RegenerateReadmeTable.cs in Arcade repo. So I didn't remove that file according to the instruction from #34907 |
Right, because we are now following a different approach where we are dynamically generating/updating aka.ms links so there's no need for the regeneration of the readme file anymore. We still haven't added the build table back to the README.md though. It should be safe to delete this. |
|
I recommend not doing this--at the very least, not as part of this PR. The task isn't exercised as part of the builds, and this is intentional. It also looks like the normal entrypoint disappeared in 42183b1#diff-f1921dfe4ae191cbfc80c608aa17dd4a. |
I see, it sounds like you're under the impression that the readme was updated for every official build? This actually hasn't changed with aka.ms link generation: the links were always being dynamically updated and the table text was always static. There's nothing new here with aka.ms links. |
Right, I thought that was the case and the regenerate-readme-table.proj was used to update it and flow it back into the public repo somehow. Sounds like the proj simply avoids the hand-editing of the build table. |
This reverts commit 037f425.
I've reverted the change. Thanks for pointing this out! |
|
What about GetTargetMachineInfo? |
This file is still used. Removing it will cause below build error: |
|
Ok, I'll deal with it in #35538. |
Deleted below files that were moved to Arcade.
BuildFPMToolPreReqs.cs
CopyNupkgAndChangeVersion.cs
CreateFrameworkListFile.cs
ExecWithRetries.cs
GenerateDebRepoUploadJsonFile.cs
GenerateJsonObjectString.cs
ProcessSharedFrameworkDeps.cs
RuntimeGraphManager.cs
RuntimeReference.cs
StabilizeWixFileId.cs
ZipFileExtractToDirectory.cs
ZipFileGetEntries.cs