[release/5.0-preview4] Add new IntPtr/UIntPtr API surface#35248
Merged
tannergooding merged 2 commits intodotnet:release/5.0-preview4from Apr 23, 2020
Merged
[release/5.0-preview4] Add new IntPtr/UIntPtr API surface#35248tannergooding merged 2 commits intodotnet:release/5.0-preview4from
tannergooding merged 2 commits intodotnet:release/5.0-preview4from
Conversation
* Add new IntPtr surface * Add new UIntPtr API surface * Add sequential layout to match [U]Int32 * Add interfaces and sequential layout * Add interfaces * Add namespaces * Add namespaces * Update UIntPtr.cs * Update IntPtr.cs * Change style * make non versionable, elide copy * fix style, elide copy, make non versionable * Fix syntax error * Fix style issues * Fix style issues * Update IntPtr.cs * Update UIntPtr.cs * Update ref assembly * Allow comparison of intptr/uintptr in Array * Fixed ELEMENT_TYPE cases, added tests based on Int32/UInt32 tests * Fixes * Update Array.cs * Update Array.cs * Update Array.cs * Update ArrayTests.cs * Update ArrayTests.cs * Update UIntPtrTests.cs * Update ArrayTests.cs * fix instance methods?? * fixes * Fixwa * fix tests * Add non versionables * fix compare methods * Fix comparison error * fix boundary * fix compares * fix maxvals * remove xunit buggy data * silly var name error * Update src/libraries/System.Private.CoreLib/src/Resources/Strings.resx Co-Authored-By: Tanner Gooding <tagoo@outlook.com> * Fix ToString Co-authored-by: Tanner Gooding <tagoo@outlook.com>
Member
Author
|
CC. @cston |
Collaborator
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Member
|
approved to merge when you have green CI/signed off. |
Member
Author
|
Realized that the ref API had the |
Member
Author
|
@Anipik, is anything further blocking this from being merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports #307 to the release/5.0-preview4 branch that was snapped yesterday. While not strictly required, this is a nice-to-have as the corresponding language feature for
nint/nuintis in for the same preview.