Improve char.ToUpperInvariant / ToLowerInvariant perf#35194
Merged
GrabYourPitchforks merged 1 commit intodotnet:masterfrom Apr 20, 2020
Merged
Improve char.ToUpperInvariant / ToLowerInvariant perf#35194GrabYourPitchforks merged 1 commit intodotnet:masterfrom
GrabYourPitchforks merged 1 commit intodotnet:masterfrom
Conversation
Member
Author
|
I also tried testing a branchless implementation but the results were about the same for the different inputs I tried. So no need to complicate the logic. |
Member
|
Should the above benchmarks be added to dotnet/performance? |
gfoidl
reviewed
Apr 20, 2020
src/libraries/System.Private.CoreLib/src/System/Globalization/TextInfo.cs
Show resolved
Hide resolved
stephentoub
reviewed
Apr 20, 2020
src/libraries/System.Private.CoreLib/src/System/Globalization/TextInfo.cs
Show resolved
Hide resolved
stephentoub
reviewed
Apr 20, 2020
src/libraries/System.Private.CoreLib/src/System/Globalization/TextInfo.cs
Show resolved
Hide resolved
tarekgh
approved these changes
Apr 20, 2020
stephentoub
approved these changes
Apr 20, 2020
Member
Author
|
Good catch @gfoidl on the benchmarks repo! I'll get that PR up before closing this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somewhat inspired by Steve's PR at #35185. Turns out we call
char.ToUpperInvariant/char.ToLowerInvariantin a few dozen places within the runtime.This PR improves these code paths by: (a) not bouncing through the
TextInfo.Invariantindirection for ASCII data or whenGlobalizationMode.Invariantis enabled; (b) inlining small methods that the JIT wasn't already inlining; and (c) tweaking the bit twiddling to get more efficient codegen.