Simplify KnownHeaders lookup in SocketsHttpHandler#34974
Merged
stephentoub merged 2 commits intodotnet:masterfrom Apr 15, 2020
Merged
Simplify KnownHeaders lookup in SocketsHttpHandler#34974stephentoub merged 2 commits intodotnet:masterfrom
stephentoub merged 2 commits intodotnet:masterfrom
Conversation
|
Tagging subscribers to this area: @dotnet/ncl |
scalablecory
approved these changes
Apr 14, 2020
davidsh
reviewed
Apr 14, 2020
src/libraries/System.Net.Http/src/System/Net/Http/Headers/KnownHeaders.cs
Outdated
Show resolved
Hide resolved
…nHeaders.cs Co-Authored-By: David Shulman <david.shulman@microsoft.com>
This was referenced Apr 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #34922 (comment)
Also added tests to make sure we're correctly looking up these headers, since it's easy to mess up.
cc: @lpereira, @scalablecory, @davidsh