ComWrappers: Add support for ICustomQueryInterface #34733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…object wrapper doesn't know about the IID but implements the interface.
jkotas
reviewed
Apr 9, 2020
jkotas
approved these changes
Apr 9, 2020
jkotas
approved these changes
Apr 9, 2020
davidwrighton
approved these changes
Apr 10, 2020
…runtime. This means we can no longer assume we are in preemptive mode during the QI. Update the ICustomQueryInterface dispatch to be okay with ANY mode. Tests needed to be updated with the ICustomQueryInterface support.
|
Hello @AaronRobinsonMSFT! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Member
Author
|
These changes are limited to the Windows platforms so merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the managed object wrapper doesn't know about the IID but implements
ICustomQueryInterface, ask the implementation to find the interface.Fixes #34717
/cc @jkoritzinsky @elinor-fung @jkotas @davidwrighton