Fix PrinterSettings.SupportsColor to use the right PInvoke #34651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @safern as an area owner |
tarekgh
reviewed
Apr 7, 2020
tarekgh
reviewed
Apr 7, 2020
src/libraries/System.Drawing.Common/tests/Printing/PrinterSettingsTests.cs
Outdated
Show resolved
Hide resolved
tarekgh
approved these changes
Apr 7, 2020
src/libraries/System.Drawing.Common/src/System/Drawing/Printing/PrinterSettings.Windows.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Apr 8, 2020
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
I have some nit comments. Please take a look.
src/libraries/System.Drawing.Common/src/System/Drawing/Printing/PrinterSettings.Windows.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Drawing.Common/tests/Printing/PrinterSettingsTests.cs
Show resolved
Hide resolved
Tanya-Solyanik
approved these changes
Apr 14, 2020
Member
Author
|
It seems like the Mono Build node didn't update in the GH UI, but the build is green: https://dev.azure.com/dnceng/public/_build/results?buildId=600616&view=logs Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to MS docs, GetDeviceCaps(BITSPIXEL) returns the "Number of adjacent color bits for each pixel."
We instead need to use DeviceCapabilities with
DC_COLORDEVICEFixes: #34630
cc: @ericstj @tarekgh