Fix wrong assert in cgroups code#34291
Merged
jkotas merged 1 commit intodotnet:masterfrom Mar 30, 2020
Merged
Conversation
There is an assert in FindCgroupPath that fires when hierarchy_root and cgroup_path_relative_to_mount are equal, which is the case for cgroups that are not named. This assert checks that the common path in those two variables ends with / which is only the case with named groups. We have never seen this assert to fire because cgroups initialization happens before the debugger support initialization in PAL and so asserts are disabled at that point. I am going to fix that in a separate PR. This problem was discovered with the standalone GC where the assert actually fires as it uses a plain C assert function. This change fixes the assert to account for the case when both the paths are the same.
Member
Author
|
cc: @omajid, @MichalStrehovsky |
jkotas
approved these changes
Mar 30, 2020
omajid
approved these changes
Mar 30, 2020
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an assert in FindCgroupPath that fires when hierarchy_root
and cgroup_path_relative_to_mount are equal, which is the case for
cgroups that are not named. This assert checks that the common
path in those two variables ends with / which is only the case
with named groups.
We have never seen this assert to fire because cgroups initialization
happens before the debugger support initialization in PAL and so
asserts are disabled at that point. I am going to fix that in a
separate PR.
This problem was discovered with the standalone GC where the assert
actually fires as it uses a plain C assert function.
This change fixes the assert to account for the case when both the
paths are the same.
Close #34287