Add (internal) Task.WhenAny(task, task) overload#34288
Merged
stephentoub merged 1 commit intodotnet:masterfrom Apr 9, 2020
Merged
Add (internal) Task.WhenAny(task, task) overload#34288stephentoub merged 1 commit intodotnet:masterfrom
stephentoub merged 1 commit intodotnet:masterfrom
Conversation
Member
|
should we tag the issue API-Needs-Work for tracking to expose it? or we are not planning to have it for 5.0? |
tarekgh
reviewed
Apr 3, 2020
src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/Task.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
#23021 is ready for review about exposing it publicly. |
tarekgh
reviewed
Apr 3, 2020
src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/Task.cs
Outdated
Show resolved
Hide resolved
tarekgh
approved these changes
Apr 3, 2020
Member
tarekgh
left a comment
There was a problem hiding this comment.
added a couple of questions but it looks good to me as it is too.
Currently internal and used as an implementation detail under Task.WhenAny(params Task[]) as well as from SemaphoreSlim. Once API reviewed, it can be made public.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently internal and used as an implementation detail under Task.WhenAny(params Task[]) as well as from SemaphoreSlim. Once API reviewed, it can be made public.
Contributes to #23021