Enable CI to run CoreCLR tests on Mono#34054
Merged
naricc merged 51 commits intodotnet:masterfrom Apr 22, 2020
Merged
Conversation
am11
reviewed
Mar 25, 2020
CoffeeFlux
reviewed
Mar 26, 2020
safern
reviewed
Apr 2, 2020
safern
reviewed
Apr 2, 2020
safern
reviewed
Apr 3, 2020
author Joseph Shields <directhex@apebox.org> 1583952716 -0400 committer Nathan Ricci <naricc@microsoft.com> 1586815263 -0400 Add Mono run of CoreCLR Pri0 tests Changes to exclude mono failures. build-test-job.yml Changes to runtime.yml Changes to runtime.yml Got rid of parameter. Removed parameter. reverse changesin runtime. Simplified some things. Combined mono/clore build-test-job.yml into one file in common. Removed onld build-test-job.yml Removed white space. Missing parens. Removed undeed mono build-test-job. Removed run-test-job.yml Added build-job back; still needed. Added back a change that got lost in merge. Got rid of compile time evaluation of runtime stuff. Moved xplat-pipeline-job to common. Updated paths. More path updates. Moved xplat-job. Undid file moves. Refer to different templates based on runtime parameters. reverted changes to build-job. Updated build-test-job. Moved to a mono version of run-test-job. Back to seperate versions of run-test-job.yml Added back mono version of run-test-job.yml Moved references to common version of build-test. Build test job.yml Moved send-to-helix-step to common. Removed mono specific send-to-helix-step. Moved run-test-job.yml into common. Fixed run-test-job. Fixed run test job again. Fixed run test job again. Fixed run test job again. Removed mono specific version of run-test-job. Removed windows from mono coreclr test platforms until that script is written. Added some variables to mono version of xplat-job. Made building tests depend explicitly on coreclr. Made mono also get CoreCLR. Fixed spacing. Fixed syntax error. build-test-job.yml Changed dispaly name. Changed dispaly name. Fixed variable name. Fixed white space. Testing some yml. Reversed changes. Removed - Used each. Add liveRuntimeBuildConfig parameter. Add liveRuntimeBuildConfig parameter. removed redundant definition. removed redundant definition. removed redundant paramter. Fixed typos, display names. Added display name. Use display name. Added missing : Fixed spelling errors. Fixed spelling error. Fixed spelling error. Canged CoreCLRProductBuild to always use release Use display name. Commented out other architecturs for debugging. Added runtimeFlavorDisplayName explicitly in runtime.yml Added missing variables to mono version of xplat-pipeline job Put in missing variables. More missing variables. More missing variables. Changed hardcoded release. Added liveRuntimeBuildConfig. Changed to parameter. Changed to parameter. Trying to make everything build in release. Messing with different configs. Made everything checked. Added runtime flavor to run-test-job name. Fixed spelling on parameters. Made all the mono stuff build in debug. Made more things debug. Changed everything to release. Made everthing release, again. Changed to run test job. Added missing space. run-test-job.yml Fixed msbuild invocation. Pushing a white space change. Removed white space change. Removed unneeded single quotes.
ff4658d to
822a7be
Compare
safern
reviewed
Apr 14, 2020
safern
reviewed
Apr 14, 2020
safern
reviewed
Apr 14, 2020
safern
reviewed
Apr 14, 2020
safern
reviewed
Apr 14, 2020
safern
reviewed
Apr 14, 2020
safern
reviewed
Apr 15, 2020
marek-safar
reviewed
Apr 15, 2020
marek-safar
reviewed
Apr 15, 2020
safern
reviewed
Apr 21, 2020
safern
reviewed
Apr 21, 2020
safern
reviewed
Apr 21, 2020
safern
reviewed
Apr 21, 2020
safern
reviewed
Apr 21, 2020
safern
reviewed
Apr 21, 2020
safern
reviewed
Apr 21, 2020
safern
approved these changes
Apr 21, 2020
Member
safern
left a comment
There was a problem hiding this comment.
Other than pending comments LGTM.
safern
reviewed
Apr 21, 2020
added 2 commits
April 21, 2020 19:24
Contributor
|
@naricc This change has broken at least the jitstress pipeline: https://dev.azure.com/dnceng/public/_build/results?buildId=613103&view=results with: |
Contributor
|
Opened #35367 to track. |
Member
|
I believe that was fiuxed by: #35311 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable CorCLR tests to run on Mono. To do this we also refactor parts of the build .yml to reduce code duplication; instead of having seperate mono/coreclr versions that are 90 % the same.