Don't probe for A/W variants of entry points on non-Windows.#33250
Merged
jkotas merged 4 commits intodotnet:masterfrom Mar 11, 2020
Merged
Don't probe for A/W variants of entry points on non-Windows.#33250jkotas merged 4 commits intodotnet:masterfrom
jkotas merged 4 commits intodotnet:masterfrom
Conversation
Collaborator
|
I couldn't add an area label to this PR. Checkout this page to find out which area owner to ping, or please add exactly one area label to help train me in the future. |
54a1f7a to
a6b7187
Compare
stephentoub
reviewed
Mar 5, 2020
Member
stephentoub
left a comment
There was a problem hiding this comment.
Should we add any tests to validate expected behavior?
jkotas
reviewed
Mar 5, 2020
jkotas
reviewed
Mar 5, 2020
jkotas
reviewed
Mar 5, 2020
AaronRobinsonMSFT
approved these changes
Mar 5, 2020
Member
|
@stephentoub I agree. Anytime we add the 'breaking-change' tag some level of testing should be a requirement. |
Member
Author
|
I've updated the ExactSpelling tests to test the new behavior. |
jkotas
approved these changes
Mar 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33246 for CoreCLR