JIT: convert codegen over to new style phases#32899
Merged
AndyAyersMS merged 1 commit intodotnet:masterfrom Feb 27, 2020
Merged
JIT: convert codegen over to new style phases#32899AndyAyersMS merged 1 commit intodotnet:masterfrom
AndyAyersMS merged 1 commit intodotnet:masterfrom
Conversation
Convert codegen over to new style phases. To facilitate this, some of the state that was passed around in locals in `genGenerateCode` are now fields on the codegen object. Also add a final "pseudo phase" in case we see very late asserts. Fixes dotnet#32497.
Member
Author
|
cc @dotnet/jit-contrib Only minimal diffs in dumps (new start/end messages for the phases). |
12 tasks
BruceForstall
approved these changes
Feb 27, 2020
Contributor
BruceForstall
left a comment
There was a problem hiding this comment.
LGTM.
You're measuring slightly different things in the phases. E.g., the phase including emitEndCodeGen() now includes a few additional things, e.g., compiler->unwindReserve(). That's probably ok.
Member
Author
|
Linux arm crossgen compare is a known issue. Both are unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert codegen over to new style phases. To facilitate this, some
of the state that was passed around in locals in
genGenerateCodeare now fields on the codegen object.
Also add a final "pseudo phase" in case we see very late asserts.
Fixes #32497.