MulticastOption.Group no longer accepts null.#32518
Merged
eerhardt merged 2 commits intodotnet:masterfrom Feb 22, 2020
Merged
Conversation
Contributor
@ericstj knows where breaking changes should be mentioned. For dotnet-api-docs, I can help. |
Contributor
There was a problem hiding this comment.
Since this API did not have triple slash comments, and is already documented in MS Docs, this new exception must be added here:
stephentoub
reviewed
Feb 19, 2020
src/libraries/System.Net.Sockets/src/System/Net/Sockets/UdpReceiveResult.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Feb 19, 2020
src/libraries/System.Net.Sockets/tests/FunctionalTests/MulticastOptionTest.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Feb 19, 2020
src/libraries/System.Net.Sockets/src/System/Net/Sockets/MulticastOption.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Feb 19, 2020
MulticastOption.Group is not supposed to accept null. If someone sets it to null, we will NRE inside of the Sockets implementation. I also fixed two small double-cast problems while I was in here. Fix dotnet#32490
Member
|
@eerhardt this is labeled breaking change. Can you please open an issue if necessary using https://github.com/dotnet/docs/issues/new?template=dotnet-breaking-change.md ? |
Member
Author
Done. dotnet/docs#19723 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MulticastOption.Group is not supposed to accept null. If someone sets it to null, we will NRE inside of the Sockets implementation.
I also fixed two small double-cast problems while I was in here.
Fix #32490
Note that this is a breaking change. I'm not sure all the ways I'm supposed to document this. If anyone has thoughts, please let me know.