[threading] Switch domain assemblies lock from OS to Coop#32502
Merged
CoffeeFlux merged 1 commit intodotnet:masterfrom Mar 2, 2020
Merged
[threading] Switch domain assemblies lock from OS to Coop#32502CoffeeFlux merged 1 commit intodotnet:masterfrom
CoffeeFlux merged 1 commit intodotnet:masterfrom
Conversation
Contributor
|
The problem seems to be that 'assemblies_lock' is not really a low level lock, its used for locking around a ton of code. |
Contributor
Author
|
Yeah, anything iterating through the domain's |
jaykrell
reviewed
Feb 18, 2020
210c48b to
eb1c8da
Compare
I don't think you can create a root domain without reaching the thread info attach call, so this should be safe to change outright.
eb1c8da to
a15d148
Compare
lambdageek
approved these changes
Feb 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think you can create a root domain without reaching the thread info attach call, so this should be safe to change outright.
Fixes #32177
We should complete mono/mono#18915 and then convert over other locks as needed, but this fixes the immediate CI hang.