Remove a couple allocations from Socket.Connect/Bind/etc.#32271
Merged
stephentoub merged 1 commit intodotnet:masterfrom Feb 14, 2020
Merged
Remove a couple allocations from Socket.Connect/Bind/etc.#32271stephentoub merged 1 commit intodotnet:masterfrom
stephentoub merged 1 commit intodotnet:masterfrom
Conversation
The Socket implementation calls the internal SnapshotAndSerialize method on a bunch of code paths, like Connect, Bind, etc. The "snapshot" part of the name comes from the time of CAS, and the implementation needed to clone the instance to make security decisions. We no longer make such decisions, but we're still cloning the objects. We can stop doing that.
davidsh
approved these changes
Feb 14, 2020
antonfirsov
approved these changes
Feb 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Socket implementation calls the internal SnapshotAndSerialize method on a bunch of code paths, like Connect, Bind, etc. The "snapshot" part of the name comes from the time of CAS (thanks for the hint, @GrabYourPitchforks), and the implementation needed to clone the instance to make security decisions. We no longer make such decisions, but we're still cloning the objects. We can stop doing that. The main change is just a few lines; I then deleted a dead function it left behind, and renamed the SnapshotAndSerialize method, which is no longer snapshotting.
From a microbenchmark doing
var s = new Socket(...); s.Connect(...);a thousand times...Before:
After:
cc: @dotnet/ncl