[loader] Parse in more netcore hosting properties#32263
Merged
CoffeeFlux merged 8 commits intodotnet:masterfrom Feb 19, 2020
Merged
[loader] Parse in more netcore hosting properties#32263CoffeeFlux merged 8 commits intodotnet:masterfrom
CoffeeFlux merged 8 commits intodotnet:masterfrom
Conversation
lambdageek
approved these changes
Feb 13, 2020
jaykrell
reviewed
Feb 13, 2020
jaykrell
reviewed
Feb 13, 2020
jaykrell
reviewed
Feb 13, 2020
jaykrell
reviewed
Feb 13, 2020
Member
|
Nit about |
Contributor
Author
|
Ah good to know, thanks! I agree it's still not a concern, but worth keeping in mind - I'll update the description to be more accurate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes some other minor cleanup to the netcore hosting functions.
Setting
assemblies_pathwithAPP_PATHSdespite it also being set byMONO_PATHdoesn't scare me too much because:MONO_PATHis probably not going through the hosting API and is usingmono-sgendirectlyAPP_PATHSunlessMicrosoft.NETCore.DotNetHostPolicy.SetAppPathsis set to 1 in the.runtimeconfig.json(which is rare, and we've worked fine withoutAPP_PATHSbeing set at all up until now)