Linux NIC speed type made long to fit the actual value#32223
Merged
ManickaP merged 5 commits intodotnet:masterfrom Feb 14, 2020
Merged
Linux NIC speed type made long to fit the actual value#32223ManickaP merged 5 commits intodotnet:masterfrom
ManickaP merged 5 commits intodotnet:masterfrom
Conversation
Member
Author
|
/azp list |
Member
Author
|
CI Failures:
|
Member
Author
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
According to AzDO, the System.Net.NetworkInformation.Tests.NetworkInterfaceBasicTest.BasicTest_AccessInstanceProperties_NoExceptions_Linux is passing on all platforms. |
wfurt
approved these changes
Feb 13, 2020
Member
wfurt
left a comment
There was a problem hiding this comment.
LGTM with change @scalablecory suggested.
halter73
reviewed
Feb 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18090
Linux pal level struct for network info had only int32 field for speed. Even though our public API has it as long. The problem was in value overflowing in calculation MBits --> Bits.