Add Interlocked unsigned and bitwise operations#32216
Add Interlocked unsigned and bitwise operations#32216stephentoub merged 4 commits intodotnet:masterfrom
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
I see some unmanaged usage with regard to job scheduling, but the scenarios for this (at least in C#) don't seem as clear-cut as the scenarios for |
src/coreclr/src/System.Private.CoreLib/src/System/Threading/Interlocked.cs
Outdated
Show resolved
Hide resolved
src/coreclr/src/System.Private.CoreLib/src/System/Threading/Interlocked.cs
Outdated
Show resolved
Hide resolved
src/coreclr/src/System.Private.CoreLib/src/System/Threading/Interlocked.cs
Outdated
Show resolved
Hide resolved
Ok, I'm going to remove it. I want to add things only when there's a strong demonstrated need, and I'm not seeing that for xor. |
src/coreclr/src/System.Private.CoreLib/src/System/Threading/Interlocked.cs
Outdated
Show resolved
Hide resolved
f33b18a to
b8d7edc
Compare
b8d7edc to
b6a86a3
Compare
Fixes #24694
Fixes #23819
@GrabYourPitchforks, are the Xor methods really necessary? Where do you expect them to be used?
cc: @jkotas, @GrabYourPitchforks, @tannergooding