Merged
Conversation
jkotas
reviewed
Feb 13, 2020
Member
jkotas
reviewed
Feb 14, 2020
This reverts commit 7fb61b3.
maryamariyan
approved these changes
Feb 14, 2020
jkotas
approved these changes
Feb 14, 2020
Member
jkotas
left a comment
There was a problem hiding this comment.
LGTM as a step towards fixing the larger problem. As discussed in the other PR, we will also need tests and fix the other structs with this problem.
Contributor
Author
|
@jkotas, @maryamariyan @danmosemsft Is there an ongoing issue with macOS builds? They seem to be failing consistently (3 times I tried). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #981
The PR adapts from the PR at #32150 and maintains the same idea around changing the pack structure of the enum on X86 execution, just before sending it over to OleDb to minimize changes in the way the structure is modified.
The basic idea that the Packing of the structure needs to be changed, stems from the investigation done by @maryamariyan .
Note: This PR changes a single struct. The other structs which are packed with size 2, should be addressed too, and I will be taking care of them in subsequent PRs.
Testing: The tests were run on x86 build with the
Microsoft.Jet.OLEDB.4.0driver which is meant for 32 bit usage.