Fix crossgen2 handling of direct calls to abstract methods#215
Merged
janvorli merged 2 commits intodotnet:masterfrom Nov 22, 2019
janvorli:fix-abstractcalls-test
Merged
Fix crossgen2 handling of direct calls to abstract methods#215janvorli merged 2 commits intodotnet:masterfrom janvorli:fix-abstractcalls-test
janvorli merged 2 commits intodotnet:masterfrom
janvorli:fix-abstractcalls-test
Conversation
This change fixes two differences between old and new crossgen in the getCallInfo method. Direct calls to abstract methods were being compiled as if they were possible and lead to runtime crash in the call chain from the PreStubWorker.
janvorli
commented
Nov 22, 2019
| if (originalMethod.Signature.IsStatic && (flags & CORINFO_CALLINFO_FLAGS.CORINFO_CALLINFO_CALLVIRT) != 0) | ||
| { | ||
| throw new BadImageFormatException(); | ||
| throw new RequiresRuntimeJitException("CallVirt to static method"); |
Member
Author
There was a problem hiding this comment.
This is not related to the fix, but it seems that we should not fail the whole build for this case, just the function compilation.
It seems that the InvalidProgramException is more appropriate.
trylek
approved these changes
Nov 22, 2019
Member
trylek
left a comment
There was a problem hiding this comment.
Looks great to me, thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes two differences between old and new crossgen in the
getCallInfo method. Direct calls to abstract methods were being compiled
as if they were possible and lead to runtime crash in the call chain
from the PreStubWorker.