Skip to content

Code clean ups (inline out var, remove unnecessary assignments)#2004

Merged
stephentoub merged 4 commits intodotnet:masterfrom
benaadams:inline-out-var
Mar 1, 2020
Merged

Code clean ups (inline out var, remove unnecessary assignments)#2004
stephentoub merged 4 commits intodotnet:masterfrom
benaadams:inline-out-var

Conversation

@benaadams
Copy link
Member

@benaadams benaadams commented Jan 22, 2020

  • Inline out variable declarations

  • Remove unnecessary assignments (including using discards for the inlined outs)

@benaadams benaadams requested a review from stephentoub January 22, 2020 07:55
@benaadams
Copy link
Member Author

benaadams commented Jan 22, 2020

Aside VS's Inline variable declarations quick option will remove nullable annotations ? so you have to add them back, not sure where to raise that?

@stephentoub
Copy link
Member

stephentoub commented Jan 22, 2020 •
edited
Loading

Aside VS's Inline variable declarations quick option will remove nullable annotations ? so you have to add them back, not sure where to raise that?

What VS version are you using?
dotnet/roslyn#38554

@benaadams
Copy link
Member Author

benaadams commented Jan 24, 2020 •
edited
Loading

16.5.0 Preview 1.0

edit see its marked as in Preview 2.0

Updating...

@stephentoub
Copy link
Member

stephentoub commented Feb 13, 2020

@benaadams, still working on this? Want to address the remaining feedback and rebase?

@benaadams
Copy link
Member Author

benaadams commented Feb 14, 2020

Want to address the remaining feedback and rebase?

I've rebased and addressed @jkotas's comment as he changed the code site in a different PR (hence conflict); so just removed the change.

However, I'm not sure how to address your comment 2004#discussion_r369603091 as it was on one of the simplest out type changes; so should I back out all the out type changes?

@stephentoub
Copy link
Member

stephentoub commented Feb 14, 2020

so should I back out all the out type changes?

No, I was mainly ranting. :)

@stephentoub stephentoub reopened this Feb 20, 2020
@benaadams
Copy link
Member Author

benaadams commented Feb 24, 2020

Rebased

@benaadams
Copy link
Member Author

benaadams commented Feb 29, 2020

Rebased

This was referenced Feb 29, 2020
Closed
Closed
@stephentoub stephentoub merged commit 0a2f0e6 into dotnet:master Mar 1, 2020
@benaadams benaadams deleted the inline-out-var branch March 1, 2020 02:34
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotas jkotas jkotas left review comments

@stephentoub stephentoub stephentoub approved these changes

Assignees

No one assigned

Labels

area-Meta

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@benaadams @stephentoub @jkotas @maryamariyan