Unify CoreLib interop files#1914
Merged
jkotas merged 1 commit intodotnet:masterfrom Jan 22, 2020
jkotas:corelibinterop
Merged
Conversation
stephentoub
reviewed
Jan 21, 2020
src/libraries/Common/src/System/Net/NetworkInformation/HostInformationPal.Windows.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 21, 2020
...em.Net.NetworkInformation/src/System/Net/NetworkInformation/SystemIPv4InterfaceProperties.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 21, 2020
.../System.Net.NetworkInformation/src/System/Net/NetworkInformation/SystemIPGlobalProperties.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 21, 2020
...es/System.Net.NetworkInformation/src/System/Net/NetworkInformation/SystemNetworkInterface.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Jan 21, 2020
- Unify more of CoreLib interop files - Replace manual interop with regular managed APIs where possible - Delete unused code Contributes to #1232
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #1232