[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mobile test suites#129226
Open
kotlarmilos wants to merge 4 commits into
Open
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mobile test suites#129226kotlarmilos wants to merge 4 commits into
kotlarmilos wants to merge 4 commits into
Conversation
…ile test suites Disable InvokeWithRefLikeArgs.MethodTakesRefToRefStructAsArg_ThrowsNSE and TensorPrimitives SpanDestinationFunctions_ValueRange on Apple mobile CoreCLR against dotnet#124344, and root the typeless System.Runtime facade in the trimmer descriptor so AssemblyLoadWithPublicKey and AssemblyGetForwardedTypesLoadFailure no longer fail to load it from the trimmed app bundle. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates several library test suites to improve reliability of Apple mobile CoreCLR test runs by conditionally disabling known failing tests and by ensuring trimming doesn’t remove a required facade assembly used by reflection tests.
Changes:
- Add
[ActiveIssue(...)]gating to skip a Moq/RefEmit-based reflection test on AppleMobile + CoreCLR. - Add
[ActiveIssue(...)]gating to skipTensorPrimitivesvalue-range coverage on AppleMobile + CoreCLR. - Update ILLink trimming descriptors to root the
System.Runtimefacade assembly so it isn’t trimmed away in theSystem.Reflection.Testsapp.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Reflection/InvokeWithRefLikeArgs.cs | Adds an AppleMobile+CoreCLR ActiveIssue skip for a Moq/RefEmit test. |
| src/libraries/System.Runtime/tests/System.Reflection.Tests/ILLink.Descriptors.xml | Roots System.Runtime in the linker descriptor to prevent it being trimmed from the test bundle. |
| src/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.cs | Adds an AppleMobile+CoreCLR ActiveIssue skip for SpanDestinationFunctions_ValueRange. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 1
Address review feedback: instead of [ActiveIssue] on the whole SpanDestinationFunctions_ValueRange theory, omit only the Tan case from the shared data provider on Apple mobile CoreCLR, preserving ValueRange coverage for the other operations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ueRange Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jun 10, 2026
Open
Open
This was referenced Jun 10, 2026
GetForwardedTypes() does not resolve the forwarded System.Object/BadImageFormatException entries on trimmed Apple CoreCLR app bundles even after rooting the System.Runtime facade, so gate the test against dotnet#124344 like the other Apple mobile CoreCLR failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Disables three Apple CoreCLR mobile test failures against #124344 and fixes one via the trimmer descriptor:
InvokeWithRefLikeArgs.MethodTakesRefToRefStructAsArg_ThrowsNSEis disabled because Moq's RefEmit codegen breaks on iOS CoreCLR.TensorPrimitives.SpanDestinationFunctions_ValueRangeis disabled becauseTandiverges by a few ULPs under FMA on arm64.AssemblyTests.AssemblyGetForwardedTypesLoadFailureis disabled becauseGetForwardedTypes()does not resolve the forwardedSystem.Object/BadImageFormatExceptionentries on trimmed Apple CoreCLR app bundles, even after rootingSystem.Runtime.AssemblyTests.AssemblyLoadWithPublicKeyis fixed by rooting the typelessSystem.Runtimefacade in the trimmer descriptor so it is not dropped from the app bundle.