Assert handle is not null in HandleToObject#126797
Merged
MichalStrehovsky merged 2 commits intodotnet:mainfrom Apr 13, 2026
Merged
Assert handle is not null in HandleToObject#126797MichalStrehovsky merged 2 commits intodotnet:mainfrom
MichalStrehovsky merged 2 commits intodotnet:mainfrom
Conversation
Add assertion to ensure handle is not null in HandleToObject method. Beforehand, this resulted in a cryptic IndexOutOfRangeException.
MichalStrehovsky
approved these changes
Apr 12, 2026
Member
MichalStrehovsky
left a comment
There was a problem hiding this comment.
The assert that we really need here is not just that the value is not null, but it also has the top bit set. Such assert should be added when #122013 is fixed.
In general the most likely reason to get the IndexOutOfRangeException is the RyuJIT bugs where it treats handle like an integer constant (forgetting it was a handle) and does some math with it. I don't remember seeing null handles. But I guess this doesn't hurt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add assertion to ensure handle is not null in HandleToObject method.
Beforehand, this resulted in a cryptic IndexOutOfRangeException.