JIT: Disable instrument_if_optimizing in libraries-pgo#126762
Merged
AndyAyersMS merged 1 commit intodotnet:mainfrom Apr 11, 2026
Merged
Conversation
Remove the instrument_if_optimizing scenario from the libraries-pgo pipeline so the very slow JIT instrumentation mode no longer runs for libraries tests. The shared scenario definition remains available for coreclr tests.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
@dotnet/jit-contrib PTAL |
Contributor
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
Member
Author
|
/azp run runtime-coreclr libraries-pgo |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the instrument_if_optimizing Helix scenario from the CoreCLR libraries-pgo pipeline so libraries PGO runs avoid the very slow “instrument while optimizing” JIT mode, while leaving the shared scenario definition available for other test groups that still use it.
Changes:
- Dropped
instrument_if_optimizingfrom theeng/pipelines/coreclr/libraries-pgo.ymlscenarios list.
EgorBo
approved these changes
Apr 10, 2026
This was referenced Apr 11, 2026
Open
Member
Author
|
Libraries pgo still has failures, but they should be easier to sort though now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the instrument_if_optimizing scenario from the libraries-pgo pipeline so the very slow JIT instrumentation mode no longer runs for libraries tests. The shared scenario definition remains available for coreclr tests.
Fixes #120902