Convert throw and thread helpers to UCO#126582
Merged
jkotas merged 15 commits intodotnet:mainfrom Apr 10, 2026
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @agocke |
227f207 to
df453ad
Compare
Member
Author
|
@EgorBot -osx_arm64 using System;
using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;
BenchmarkSwitcher
.FromAssembly(typeof(ExceptionBench).Assembly)
.Run(args);
[MemoryDiagnoser]
[SimpleJob(warmupCount: 3, iterationCount: 10)]
public class ExceptionBench
{
private static volatile int _sink;
[Benchmark]
public void ThrowCatch()
{
try
{
Thrower();
}
catch (InvalidOperationException ex)
{
_sink = ex.HResult;
}
}
private static void Thrower()
{
throw new InvalidOperationException("boom");
}
[Benchmark]
public void NullRefThrow()
{
try
{
object o = null!;
_ = o.ToString(); // NullRef
}
catch
{
}
}
[Benchmark]
public void Rethrow()
{
try
{
try
{
Thrower();
}
catch
{
throw;
}
}
catch
{
}
}
} |
jkotas
reviewed
Apr 6, 2026
src/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs
Outdated
Show resolved
Hide resolved
janvorli
reviewed
Apr 7, 2026
src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs
Outdated
Show resolved
Hide resolved
2d3d910 to
ff25723
Compare
jkotas
reviewed
Apr 8, 2026
This was referenced Apr 8, 2026
Open
janvorli
reviewed
Apr 8, 2026
src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
jkotas
reviewed
Apr 8, 2026
src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs
Show resolved
Hide resolved
jkotas
reviewed
Apr 9, 2026
jkotas
approved these changes
Apr 10, 2026
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to prio3 from #123864