[Wasm RyuJIT] Fixes for two codegen asserts#126514
Open
kg wants to merge 11 commits intodotnet:mainfrom
Open
Conversation
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes two WebAssembly RyuJIT codegen assertion failures by handling edge cases around struct locals whose effective “register type” is not directly representable as TYP_STRUCT in wasm codegen.
Changes:
- Ignore leftover
GT_LCL_VARnodes whose computed register type isTYP_UNDEFwhen they are marked asIsUnusedValue()(e.g., after block-store pruning in LIR). - Ensure
GT_STORE_LCL_VARfor enregistered struct locals uses the struct layout’s register type when determining thelocal.setoperand size.
Member
Author
|
@dotnet/jit-contrib PTAL |
kg
commented
Apr 6, 2026
This was referenced Apr 9, 2026
Open
jakobbotsch
reviewed
Apr 9, 2026
jakobbotsch
reviewed
Apr 11, 2026
jakobbotsch
approved these changes
Apr 11, 2026
Member
jakobbotsch
left a comment
There was a problem hiding this comment.
LGTM with some minor comments
…]:op_Multiply caused by dead store removal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes BitConverter.ToBFloat16 and Vector`1.op_Multiply