Merge hotreload-utils source into runtime repo by steveisok · Pull Request #126512 · dotnet/runtime

steveisok · 2026-04-03T18:35:24Z

Copy the hotreload-utils source code from dotnet/hotreload-utils into src/tools/hotreload-delta-gen/ and replace the NuGet PackageReference with direct in-repo MSBuild targets, eliminating the cross-repo dependency.

Changes:

Add 5 projects + shared code from hotreload-utils under src/tools/hotreload-delta-gen/
Create eng/testing/hotreload-delta-gen.targets replacing the NuGet package's .targets file
Update 3 consumers (ApplyUpdate tests, WASM HotReload test, Mono sample) to import local targets instead of NuGet package
Add BuildTool and Tasks to src/libraries/pretest.proj for build ordering
Remove hotreload-utils dependency from eng/Version.Details.xml and eng/Version.Details.props
Suppress analyzers on imported code (RunAnalyzers=false) matching the illink pattern

Copy the hotreload-utils source code from dotnet/hotreload-utils into src/tools/hotreload-delta-gen/ and replace the NuGet PackageReference with direct in-repo MSBuild targets, eliminating the cross-repo dependency. Changes: - Add 5 projects + shared code from hotreload-utils under src/tools/hotreload-delta-gen/ - Create eng/testing/hotreload-delta-gen.targets replacing the NuGet package's .targets file - Update 3 consumers (ApplyUpdate tests, WASM HotReload test, Mono sample) to import local targets instead of NuGet package - Add BuildTool and Tasks to src/libraries/pretest.proj for build ordering - Remove hotreload-utils dependency from eng/Version.Details.xml and eng/Version.Details.props - Suppress analyzers on imported code (RunAnalyzers=false) matching the illink pattern Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

dotnet-policy-service · 2026-04-03T18:36:42Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR vendors the hotreload-utils delta generation toolchain into the runtime repo under src/tools/hotreload-delta-gen/, replaces the external NuGet-based integration with in-repo MSBuild targets, and updates existing consumers to use the in-repo targets.

Changes:

Added in-repo hot reload delta generator source (tool + MSBuild task + shared data/types) under src/tools/hotreload-delta-gen/.
Introduced eng/testing/hotreload-delta-gen.targets to replace the NuGet package .targets and updated consumers to import it.
Removed the dotnet/hotreload-utils dependency from versioning files and ensured build ordering via src/libraries/pretest.proj.

Reviewed changes

Copilot reviewed 43 out of 43 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/Util/FSWGen.cs	Adds FileSystemWatcher-to-Channel async event streaming for live delta generation.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/Util/AsyncEnumerableExtras.cs	Adds helper to provide an empty `IAsyncEnumerable<T>`.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/Script/ParsedScript.cs	Adds parsed-script representation for scripted delta runs.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/Script/Json/Parsing.cs	Adds JSON parsing for scripted delta input.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/Runners/ScriptRunner.cs	Adds runner that reads a script file and generates deltas.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/Runners/LiveRunner.cs	Adds runner that watches the filesystem for live edits and generates deltas.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/Runner.cs	Adds common runner orchestration (baseline setup, capability handling, delta loop).
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/Plan/Change.cs	Adds plan/change primitives used across scripted/live modes.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/Microsoft.DotNet.HotReload.Utils.Generator.csproj	Defines the generator project and Roslyn/MSBuild dependencies.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/EnC/EditAndContinueCapabilities.cs	Vendors EnC capability enum used for Roslyn Hot Reload integration.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/EditAndContinueCapabilitiesParser.cs	Adds parsing of capability strings into enum values.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/DocResolver.cs	Adds file-path → `DocumentId` mapping for Roslyn documents.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/DiffyException.cs	Adds typed exception with process exit code propagation.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/DeltaProject.cs	Core delta build logic using Roslyn HotReloadService.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/DeltaOutputStreams.cs	Wraps delta output streams and disposal semantics.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/DeltaNaming.cs	Defines naming convention for emitted delta artifacts per revision.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/Delta.cs	Defines delta input record for the generation pipeline.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/Config.cs	Adds config model and builder for scripted/live invocation.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/BaselineProject.cs	Adds baseline project loading and HotReloadService session setup.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/BaselineArtifacts.cs	Defines baseline artifacts bundle passed through generation pipeline.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator.Tasks/Microsoft.DotNet.HotReload.Utils.Generator.Tasks.csproj	Adds MSBuild task project used by the new targets file.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator.Tasks/HotReloadDeltaGeneratorComputeScriptOutputs.cs	Adds MSBuild task to compute incremental inputs/outputs from the delta script.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator.Frontend/Microsoft.DotNet.HotReload.Utils.Generator.Frontend.csproj	Adds CLI frontend project for the generator.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator.Frontend/Frontend.cs	Adds argument parsing and exit-code handling for CLI invocation.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator.Data/UpdateHandlerInfo.cs	Adds JSON-serializable update handler info payload.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator.Data/Script/Json/ScriptCapabilitiesConverter.cs	Adds JSON converter to support capabilities as string or string array.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator.Data/Script/Json/Script.cs	Adds JSON model types for delta scripts.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator.Data/OutputSummary/OutputSummary.cs	Adds JSON model types for delta output summaries.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator.Data/Microsoft.DotNet.HotReload.Utils.Generator.Data.csproj	Adds data-only project for shared contracts.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator.BuildTool/README.md	Documents the build tool usage (historical/package-oriented wording).
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator.BuildTool/Program.cs	Adds entrypoint forwarding to the CLI frontend.
src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator.BuildTool/Microsoft.DotNet.HotReload.Utils.Generator.BuildTool.csproj	Adds executable build-tool project.
src/tools/hotreload-delta-gen/Directory.Build.targets	Imports parent tool build targets for this tool subtree.
src/tools/hotreload-delta-gen/Directory.Build.props	Sets TFM/lang/nullable and disables analyzers for imported code.
src/tools/hotreload-delta-gen/Common/TempDirectory.cs	Adds temp directory helper.
src/tests/FunctionalTests/WebAssembly/Browser/HotReload/ApplyUpdateReferencedAssembly/ApplyUpdateReferencedAssembly.csproj	Switches from NuGet package reference to importing in-repo targets.
src/mono/sample/mbr/console/ConsoleDelta.csproj	Switches from NuGet package reference to importing in-repo targets.
src/libraries/System.Runtime.Loader/tests/ApplyUpdate/Directory.Build.targets	Imports in-repo hotreload delta gen targets for ApplyUpdate tests.
src/libraries/System.Runtime.Loader/tests/ApplyUpdate/Directory.Build.props	Removes NuGet package reference for delta generation in ApplyUpdate tests.
src/libraries/pretest.proj	Adds tool/task projects to pretest build ordering.
eng/Version.Details.xml	Removes hotreload-utils dependency entry.
eng/Version.Details.props	Removes hotreload-utils version properties.
eng/testing/hotreload-delta-gen.targets	New in-repo MSBuild targets replacing the NuGet-provided `.targets`.

src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/Util/FSWGen.cs

...n/Microsoft.DotNet.HotReload.Utils.Generator.Data/Script/Json/ScriptCapabilitiesConverter.cs

...rosoft.DotNet.HotReload.Utils.Generator.Tasks/HotReloadDeltaGeneratorComputeScriptOutputs.cs

...tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/Runners/ScriptRunner.cs

src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/Plan/Change.cs

src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/BaselineArtifacts.cs

...tNet.HotReload.Utils.Generator.Tasks/Microsoft.DotNet.HotReload.Utils.Generator.Tasks.csproj

...Microsoft.DotNet.HotReload.Utils.Generator/Microsoft.DotNet.HotReload.Utils.Generator.csproj

src/tools/hotreload-delta-gen/Directory.Build.props

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>

Copilot

Pull request overview

Copilot reviewed 43 out of 43 changed files in this pull request and generated 5 comments.

src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/BaselineProject.cs

eng/testing/hotreload-delta-gen.targets

src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator.Frontend/Frontend.cs

src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/BaselineProject.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 43 out of 43 changed files in this pull request and generated 2 comments.

eng/testing/hotreload-delta-gen.targets

src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/BaselineArtifacts.cs

akoeplinger · 2026-04-10T16:14:08Z

/ba-g unrelated infrastructure failures

steveisok requested a review from vitek-karas as a code owner April 3, 2026 18:35

steveisok requested review from akoeplinger, Copilot and thaystg April 3, 2026 18:35

github-actions bot added the area-Infrastructure label Apr 3, 2026

github-project-automation bot added this to Runtime Infra Apr 3, 2026

dotnet-policy-service bot assigned steveisok Apr 3, 2026

Copilot started reviewing on behalf of steveisok April 3, 2026 18:36 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

akoeplinger approved these changes Apr 8, 2026

View reviewed changes

thaystg approved these changes Apr 8, 2026

View reviewed changes

akoeplinger approved these changes Apr 8, 2026

View reviewed changes

...tNet.HotReload.Utils.Generator.Tasks/Microsoft.DotNet.HotReload.Utils.Generator.Tasks.csproj Outdated Show resolved Hide resolved

...Microsoft.DotNet.HotReload.Utils.Generator/Microsoft.DotNet.HotReload.Utils.Generator.csproj Outdated Show resolved Hide resolved

akoeplinger reviewed Apr 8, 2026

View reviewed changes

src/tools/hotreload-delta-gen/Directory.Build.props Show resolved Hide resolved

Apply suggestions from code review

5c7d08f

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>

Copilot AI review requested due to automatic review settings April 8, 2026 19:08

Copilot started reviewing on behalf of akoeplinger April 8, 2026 19:10 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

Merge branch 'main' into merge-hotreload-utils

8dbe9ef

This was referenced Apr 9, 2026

Sometimes the helix SDK uses GetWorkItemsAsync when workitems aren't done processing. dotnet/dnceng#6011

Open

Mono assertion running WASM trimming tests #126675

Open

Merge branch 'main' into merge-hotreload-utils

5f447b1

Copilot AI review requested due to automatic review settings April 9, 2026 14:32

Copilot started reviewing on behalf of akoeplinger April 9, 2026 14:34 View session

akoeplinger and others added 2 commits April 9, 2026 16:34

Apply suggestions from code review

3d083f5

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Apply suggestion from @Copilot

3ed9426

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI reviewed Apr 9, 2026

View reviewed changes

eng/testing/hotreload-delta-gen.targets Show resolved Hide resolved

src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/BaselineArtifacts.cs Show resolved Hide resolved

Merge branch 'main' into merge-hotreload-utils

88e8e05

akoeplinger approved these changes Apr 10, 2026

View reviewed changes

akoeplinger merged commit 5cb7b8c into dotnet:main Apr 10, 2026
170 of 176 checks passed

github-project-automation bot moved this to Done in Runtime Infra Apr 10, 2026

akoeplinger deleted the merge-hotreload-utils branch April 10, 2026 16:19

This was referenced Apr 10, 2026

Unable to pull image from mcr.microsoft.com #117164

Open

Assertion failure in ConnectAsync_WithBuffer_Succeeds on Android/MacCatalyst/tvOS (Mono/CoreCLR/NativeAOT) #125825

Open

System.Net.NameResolution.Tests DNS failures: Name or service not known #126641

Open

dotnet-maestro bot mentioned this pull request Apr 11, 2026

[main] Source code updates from dotnet/runtime dotnet/dotnet#5987

Open

Copilot AI mentioned this pull request Apr 11, 2026

Fix WasmTestOnChrome: exclude browser/wasi from gen-debug-dump-docs.py helix post-command #126789

Open

1 task

Conversation

steveisok commented Apr 3, 2026

Uh oh!

dotnet-policy-service bot commented Apr 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

akoeplinger commented Apr 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants