[Wasm RyuJit] Track stackifier temps by actual jit type#126215
Merged
AndyAyersMS merged 1 commit intodotnet:mainfrom Mar 27, 2026
Merged
[Wasm RyuJit] Track stackifier temps by actual jit type#126215AndyAyersMS merged 1 commit intodotnet:mainfrom
AndyAyersMS merged 1 commit intodotnet:mainfrom
Conversation
Mainly so we can distinguish GC types from non-GC types. Fixes an issue in dotnet#125756
Member
Author
|
@dotnet/jit-contrib PTAL Fixes #125756 (comment) |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
SingleAccretion
approved these changes
Mar 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the WASM JIT stackifier’s temporary-local reuse bookkeeping to key temps by the actual JIT var_types (via genActualType) rather than by the coarser WasmValueType, enabling GC-tracked types (e.g., TYP_REF / TYP_BYREF) to be distinguished from non-GC types while reusing temps.
Changes:
- Change stackifier temp pools from
WasmValueType::Countbuckets toTYP_COUNTbuckets. - Index temp reuse/free lists by
genActualType(...)instead ofActualTypeToWasmValueType(...).
kg
approved these changes
Mar 27, 2026
This was referenced Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly so we can distinguish GC types from non-GC types.
Fixes an issue in #125756