Skip to content

[android] Enable exceptions smoke test#126144

Merged
eduardo-vp merged 3 commits intodotnet:mainfrom
eduardo-vp:naot-smoke-test-exceptions
Apr 1, 2026
Merged

[android] Enable exceptions smoke test#126144
eduardo-vp merged 3 commits intodotnet:mainfrom
eduardo-vp:naot-smoke-test-exceptions

Conversation

@eduardo-vp
Copy link
Copy Markdown
Member

@eduardo-vp eduardo-vp commented Mar 26, 2026

Similar to #73487, we should check the processor count. If it's a single processor, server GC is not enabled.

Fixes #121353.

@eduardo-vp
Copy link
Copy Markdown
Member Author

/azp run runtime-nativeaot-outerloop

@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky
Copy link
Copy Markdown
Member

/azp run runtime-androidemulator, runtime-android

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@MichalStrehovsky
Copy link
Copy Markdown
Member

(We don't run device testing in the nativeaot-outerloop pipeline)

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the NativeAOT Exceptions smoke test to always enforce the “server GC enabled” requirement (including on Android), so the test also validates server-GC configuration rather than skipping that validation on specific platforms.

Changes:

  • Removed the Android-only exemption around the server-GC check in BringUpTest.Main.
  • The test now returns early if server GC is not enabled regardless of OS.

Comment thread src/tests/nativeaot/SmokeTests/Exceptions/Exceptions.cs
@eduardo-vp
Copy link
Copy Markdown
Member Author

/azp run runtime-androidemulator, runtime-android

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@eduardo-vp
Copy link
Copy Markdown
Member Author

/azp run runtime-androidemulator, runtime-android

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@eduardo-vp
Copy link
Copy Markdown
Member Author

Copilot AI review requested due to automatic review settings April 1, 2026 01:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread src/tests/nativeaot/SmokeTests/Exceptions/Exceptions.cs
@eduardo-vp
Copy link
Copy Markdown
Member Author

/azp run runtime-androidemulator, runtime-android

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

Comment thread src/tests/nativeaot/SmokeTests/Exceptions/Exceptions.cs
Copy link
Copy Markdown
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case, the change is good

@eduardo-vp eduardo-vp changed the title Native AOT Exceptions smoke test [android] Enable exceptions smoke test Apr 1, 2026
@eduardo-vp eduardo-vp marked this pull request as ready for review April 1, 2026 07:59
@eduardo-vp
Copy link
Copy Markdown
Member Author

/ba-g unrelated failures

@eduardo-vp eduardo-vp merged commit ee8c042 into dotnet:main Apr 1, 2026
100 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[naot][android] Exceptions smoke test fails with exit code 42

4 participants