Skip to content

Remove dead LastReportedFuncletInfo struct#126116

Merged
max-charlamb merged 2 commits intomainfrom
copilot/remove-dead-lastreportedfuncletinfo-code
Mar 27, 2026
Merged

Remove dead LastReportedFuncletInfo struct#126116
max-charlamb merged 2 commits intomainfrom
copilot/remove-dead-lastreportedfuncletinfo-code

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 25, 2026 •
edited
Loading

PR #119863 moved CoreCLR EH second-pass logic to native code and removed all runtime usage of the funclet saved-slot reporting feature, but left behind an orphaned definition. This removes it.

Description

  • LastReportedFuncletInfo struct (vm/exinfo.h) — struct with no references anywhere in the codebase; deleted.

No functional behavior changes — the removed struct was entirely unreachable.

💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

@dotnet-policy-service
Copy link
Copy Markdown
Contributor

dotnet-policy-service bot commented Mar 25, 2026

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Copilot AI requested a review from max-charlamb March 25, 2026 19:24
This was referenced Mar 26, 2026
Closed
Open
Open
@max-charlamb
Copy link
Copy Markdown
Member

max-charlamb commented Mar 26, 2026

@copilot, lets trim this PR down to just removing the LastReportedFuncletInfo struct. The other flag could in theory be used.

@max-charlamb
Revert ReportFPBasedSlotsOnly removal; keep only LastReportedFuncletI…
c88ce33 
…nfo deletion

Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/8fca3dc9-3d64-4bff-be2b-096e511c609f
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 26, 2026

@copilot, lets trim this PR down to just removing the LastReportedFuncletInfo struct. The other flag could in theory be used.

Done — ReportFPBasedSlotsOnly and all related changes in eetwain.h and gcinfodecoder.h have been restored (commit c88ce33). The PR now only removes the LastReportedFuncletInfo struct from vm/exinfo.h.

Copilot AI changed the title Remove dead LastReportedFuncletInfo and ReportFPBasedSlotsOnly code Remove dead LastReportedFuncletInfo struct Mar 26, 2026
@max-charlamb max-charlamb requested a review from janvorli March 26, 2026 14:48
@build-analysis build-analysis bot mentioned this pull request Mar 26, 2026
Open
3 tasks
@max-charlamb max-charlamb marked this pull request as ready for review March 27, 2026 15:47
Copilot AI review requested due to automatic review settings March 27, 2026 15:47
@max-charlamb
Copy link
Copy Markdown
Member

max-charlamb commented Mar 27, 2026

@copilot, can you look into the CI failures?

Copilot AI reviewed Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the now-unreferenced LastReportedFuncletInfo struct from CoreCLR exception-handling headers, cleaning up leftover definitions after EH second-pass logic moved to native code.

Changes:

  • Deleted the unused LastReportedFuncletInfo struct from vm/exinfo.h.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 27, 2026 •
edited
Loading

@copilot, can you look into the CI failures?

All 3 failures are unrelated to this PR's change:

  • System.Formats.Nrbf.Tests (Libraries, Windows x64) — NRBF serialization tests, no connection to exinfo.h
  • AppHost.Bundle.Tests (osx-x64 Installer) — host bundle tests, no connection to exinfo.h
  • Regression_3 (CoreCLR Pri0 Runtime, osx x64 checked) — coreclr regression tests

The CI analysis confirms prCorrelation.hasCorrelation = false — none of the failing jobs touch files changed by this PR. These look like pre-existing flaky failures. A /azp run retry should clear them.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • helixr1107v0xdcypoyl9e7f.blob.core.windows.net
    • Triggering command: /usr/bin/pwsh pwsh .github/skills/ci-analysis/scripts/Get-CIStatus.ps1 -PRNumber 126116 -ShowLogs (dns block)
  • helixr1107v0xdeko0k025g8.blob.core.windows.net
    • Triggering command: /usr/bin/pwsh pwsh .github/skills/ci-analysis/scripts/Get-CIStatus.ps1 -PRNumber 126116 -ShowLogs (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI requested a review from max-charlamb March 27, 2026 15:53
@build-analysis build-analysis bot mentioned this pull request Mar 27, 2026
Closed
@max-charlamb max-charlamb merged commit dad22b1 into main Mar 27, 2026
115 of 118 checks passed
@max-charlamb max-charlamb deleted the copilot/remove-dead-lastreportedfuncletinfo-code branch March 27, 2026 22:15
@dotnet-maestro dotnet-maestro bot mentioned this pull request Mar 28, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@janvorli janvorli janvorli approved these changes

@max-charlamb max-charlamb Awaiting requested review from max-charlamb

Assignees

@max-charlamb max-charlamb

Copilot code review Copilot

Labels

area-VM-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@max-charlamb @janvorli