Add linux_arm and windows_x86 to cDAC dump test platforms by max-charlamb · Pull Request #125793 · dotnet/runtime

max-charlamb · 2026-03-19T17:50:15Z

Adds 32-bit platform coverage to the cDAC dump test Helix infrastructure:

windows_x86: Runs on Windows.11.Amd64.Client.Open via WoW64 (same queue as x64)
linux_arm: Runs on containerized ARM32 Helix queue (helix_linux_arm32_oldest — Debian on ARM64 hardware)

Depends on #125841 which fixes cDAC dump tests on 32-bit ARM targets.

Changes

eng/pipelines/cdac/prepare-cdac-helix-steps.yml: Added queue switch cases for windows_x86 and linux_arm
eng/pipelines/runtime-diagnostics.yml: Added linux_arm and windows_x86 to cdacDumpPlatforms defaults, publish dump artifacts on test failure
src/native/managed/cdac/tests/DumpTests/EnableUnsignedDac.props: Extracted shared unsigned DAC registry logic with WoW64 /reg:32 support for x86
src/native/managed/cdac/tests/DumpTests/cdac-dump-helix.proj: Preserve test exit code through tar command, import shared DAC props

Testing

CI validates all 6 platforms: windows_x64, windows_x86, windows_arm64, linux_x64, linux_arm64, linux_arm.

dotnet-policy-service · 2026-03-19T17:51:32Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

Adds 32-bit platform coverage to the cDAC dump test Helix infrastructure by enabling windows_x86 and linux_arm as first-class platforms in the runtime diagnostics pipeline, ensuring dump generation/testing exercises more architecture combinations.

Changes:

Expanded cdacDumpPlatforms defaults to include windows_x86 and linux_arm.
Added a Helix platforms variable for helix_windows_x86.
Updated cDAC Helix queue selection logic to route windows_x86 and linux_arm to appropriate queues.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
eng/pipelines/runtime-diagnostics.yml	Adds `windows_x86` and `linux_arm` to the default cDAC dump test platform list.
eng/pipelines/helix-platforms.yml	Introduces a Helix queue variable for Windows x86 runs (via WoW64 on x64 machines).
eng/pipelines/cdac/prepare-cdac-helix-steps.yml	Extends the platform→Helix-queue mapping to support `windows_x86` and `linux_arm`.

eng/pipelines/helix-platforms.yml

Copilot

Pull request overview

This PR expands cDAC dump-test Helix coverage to include two additional 32-bit target platforms (Windows x86 via WoW64 and Linux ARM32 via containerized Helix queues), and adds infrastructure to make dump artifacts easier to retrieve from Helix runs.

Changes:

Add windows_x86 and linux_arm to the default cdacDumpPlatforms matrix in the runtime diagnostics pipeline.
Extend cDAC Helix queue selection logic to map windows_x86 and linux_arm to appropriate Helix queues.
Add dump tarball upload/download wiring for cDAC dump tests.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
`src/native/managed/cdac/tests/DumpTests/cdac-dump-helix.proj`	Adds tar creation/upload + attempts to download `dumps.tar.gz` from Helix results for dump tests/dumpgen.
`eng/pipelines/runtime-diagnostics.yml`	Adds `windows_x86`/`linux_arm` to cDAC dump platform defaults; quotes Helix queue param; publishes Helix results on failure for single-leg runs.
`eng/pipelines/helix-platforms.yml`	Introduces a `helix_windows_x86` queue alias (WoW64 on x64 Windows 10 queue).
`eng/pipelines/cdac/prepare-cdac-helix-steps.yml`	Adds queue switch cases for `windows_x86` and `linux_arm`.

src/native/managed/cdac/tests/DumpTests/cdac-dump-helix.proj

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

eng/pipelines/cdac/prepare-cdac-helix-steps.yml

src/native/managed/cdac/tests/DumpTests/cdac-dump-helix.proj

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

src/native/managed/cdac/tests/DumpTests/cdac-dump-helix.proj

eng/pipelines/cdac/prepare-cdac-helix-steps.yml

Add 32-bit platform coverage to the cDAC dump test Helix infrastructure: - windows_x86: runs on Windows.10.Amd64.Open via WoW64 - linux_arm: runs on containerized ARM32 Helix queue (Debian on ARM64) Also adds helix_windows_x86 variable to helix-platforms.yml for queue name centralization. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

The containerized ARM32 queue name contains parentheses which bash interprets as subshell syntax. Quoting the /p:HelixTargetQueues argument prevents this. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

… unused variable - Windows: save test ERRORLEVEL before tar runs, exit /b 1 if tests failed - Unix: capture test exit code in _rc before tar, exit with it after - Fix comment that incorrectly said tar runs only on failure - Remove unused helix_windows_x86 variable from helix-platforms.yml Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

src/native/managed/cdac/tests/DumpTests/DumpTests.targets

The file contains a Target element, so .targets is the correct extension per MSBuild convention. It's a separate file because both DumpTests.targets and cdac-dump-helix.proj import it — the former uses the target for local builds, the latter uses the properties for Helix pre-commands. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…s.targets EnableUnsignedDac.props now contains only shared properties (DacRegAdd, DacRegAdd32) without the underscore prefix since they are the public interface. The _EnableUnsignedDacWindows target stays in DumpTests.targets where it belongs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

src/native/managed/cdac/tests/DumpTests/DumpTests.targets

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

max-charlamb · 2026-03-25T16:10:29Z

/ba-g cDAC only pipeline change

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings March 19, 2026 17:50

github-actions bot added the area-Infrastructure label Mar 19, 2026

github-project-automation bot added this to Runtime Infra Mar 19, 2026

dotnet-policy-service bot assigned max-charlamb Mar 19, 2026

max-charlamb marked this pull request as draft March 19, 2026 17:52

Copilot started reviewing on behalf of max-charlamb March 19, 2026 17:52 View session

Copilot AI reviewed Mar 19, 2026

View reviewed changes

eng/pipelines/helix-platforms.yml Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings March 19, 2026 21:14

Copilot started reviewing on behalf of max-charlamb March 19, 2026 21:15 View session

Copilot AI reviewed Mar 19, 2026

View reviewed changes

src/native/managed/cdac/tests/DumpTests/cdac-dump-helix.proj Outdated Show resolved Hide resolved

src/native/managed/cdac/tests/DumpTests/cdac-dump-helix.proj Outdated Show resolved Hide resolved

src/native/managed/cdac/tests/DumpTests/cdac-dump-helix.proj Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings March 20, 2026 15:05

Copilot started reviewing on behalf of max-charlamb March 20, 2026 15:08 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

eng/pipelines/cdac/prepare-cdac-helix-steps.yml Show resolved Hide resolved

src/native/managed/cdac/tests/DumpTests/cdac-dump-helix.proj Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings March 20, 2026 18:31

max-charlamb force-pushed the cdac-dumptests-32bit branch from bd65a1a to 39eeff7 Compare March 20, 2026 18:31

Copilot started reviewing on behalf of max-charlamb March 20, 2026 18:33 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

src/native/managed/cdac/tests/DumpTests/cdac-dump-helix.proj Outdated Show resolved Hide resolved

src/native/managed/cdac/tests/DumpTests/cdac-dump-helix.proj Outdated Show resolved Hide resolved

eng/pipelines/cdac/prepare-cdac-helix-steps.yml Show resolved Hide resolved

This was referenced Mar 20, 2026

[macOS] SendTo_.*.Datagram_UDP_AccessDenied_Throws_DoesNotBind cannot reach host #114450

Open

Assertion failure in ConnectAsync_WithBuffer_Succeeds on Android/MacCatalyst/tvOS (Mono/CoreCLR/NativeAOT) #125825

Open

max-charlamb and others added 2 commits March 20, 2026 15:46

Quote HelixTargetQueues in sendParams for bash safety

54a72fb

The containerized ARM32 queue name contains parentheses which bash interprets as subshell syntax. Quoting the /p:HelixTargetQueues argument prevents this. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

max-charlamb marked this pull request as ready for review March 24, 2026 14:34

Copilot started reviewing on behalf of max-charlamb March 24, 2026 14:34 View session

Copilot AI reviewed Mar 24, 2026

View reviewed changes

max-charlamb requested review from barosiak, hoyosjs, noahfalk and rcj1 March 24, 2026 17:35

Copilot AI review requested due to automatic review settings March 24, 2026 19:04

max-charlamb force-pushed the cdac-dumptests-32bit branch from f99432d to 8fd98e7 Compare March 24, 2026 19:04

Copilot started reviewing on behalf of max-charlamb March 24, 2026 19:05 View session

Copilot AI reviewed Mar 24, 2026

View reviewed changes

noahfalk approved these changes Mar 24, 2026

View reviewed changes

hoyosjs reviewed Mar 25, 2026

View reviewed changes

src/native/managed/cdac/tests/DumpTests/DumpTests.targets Show resolved Hide resolved

max-charlamb and others added 2 commits March 25, 2026 10:39

Copilot AI review requested due to automatic review settings March 25, 2026 14:44

Copilot started reviewing on behalf of max-charlamb March 25, 2026 14:45 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

src/native/managed/cdac/tests/DumpTests/DumpTests.targets Outdated Show resolved Hide resolved

Update src/native/managed/cdac/tests/DumpTests/DumpTests.targets

ad0ef9c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 25, 2026 16:10

max-charlamb merged commit deb317e into dotnet:main Mar 25, 2026
17 of 18 checks passed

max-charlamb deleted the cdac-dumptests-32bit branch March 25, 2026 16:10

github-project-automation bot moved this to Done in Runtime Infra Mar 25, 2026

Copilot started reviewing on behalf of max-charlamb March 25, 2026 16:11 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

This was referenced Mar 25, 2026

Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009

Open

Unable to checkout dotnet/dnceng#4115

Open

dotnet-maestro bot mentioned this pull request Mar 26, 2026

[main] Source code updates from dotnet/runtime dotnet/dotnet#5714

Merged

Conversation

max-charlamb commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Testing

Uh oh!

dotnet-policy-service bot commented Mar 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

max-charlamb commented Mar 25, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

max-charlamb commented Mar 19, 2026 •

edited

Loading