Add regression tests for ilc --help instruction set help text#125735
Closed
Add regression tests for ilc --help instruction set help text#125735
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
…lid CPU groups) Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
…tive comparison Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix duplicate entries in ilc --help instruction set output
Add regression tests for ilc --help instruction set help text
Mar 18, 2026
Member
|
Not sure this warrants additional tests if it's already fixed main. |
This was referenced Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ilc --helpoutput for--instruction-sethad two issues: massive duplicates in per-architecture instruction set lists (e.g.,base, base, base, avx2, avx2, avx2, ...) and listing the removedx86-64predefined CPU group that produces "Unrecognized instruction set" errors when used.Both issues are already fixed in
main— duplicates byDistinctBy(PR #119368), andx86-64removal fromInstructionSetDesc.txt. This PR adds regression tests to prevent recurrence:HelpTextShowsNoDuplicateInstructionSetNames— simulates the exactDistinctBy+Specifiablelogic fromPrintExtendedHelpand asserts uniqueness per architectureAllSpecifiableNamesAppearInHelpText— verifiesDistinctByordering doesn't shadow specifiable names behind non-specifiable entries with the same keyAllCpuGroupNamesResolveToValidInstructionSets— exercisesInstructionSetSupportBuilder.AddSupportedInstructionSetfor every predefined CPU group to catch stale/broken group definitionsAllCpuGroupNamesAreUnique/NoPredefinedGroupNamedX86Dash64WithoutVersion— guards against re-introducing removed or duplicate group namesOriginal prompt
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.