[cDAC] Implement GetLastExceptionState on IXCLRDataTask#125540
Merged
barosiak merged 1 commit intodotnet:mainfrom Mar 16, 2026
Merged
[cDAC] Implement GetLastExceptionState on IXCLRDataTask#125540barosiak merged 1 commit intodotnet:mainfrom
barosiak merged 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for retrieving a thread’s last thrown exception state through the cDAC legacy IXCLRDataTask surface, and introduces tests to validate the new behavior.
Changes:
- Updates
IXCLRDataTask.GetLastExceptionStateto useDacComNullableByRef<IXCLRDataExceptionState>(consistent with other legacy-layer COM out parameters). - Implements
ClrDataTask.GetLastExceptionStateusingThreadData.LastThrownObjectHandleto construct aClrDataExceptionState. - Adds new unit tests covering
GetLastExceptionStatesuccess and failure cases, including “no previous exception info” behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/native/managed/cdac/tests/ClrDataExceptionStateTests.cs | Extends test helpers and adds new test coverage for GetLastExceptionState. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/IXCLRData.cs | Changes the COM interface signature for GetLastExceptionState to use DacComNullableByRef. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataTask.cs | Implements GetLastExceptionState backed by ThreadData.LastThrownObjectHandle. |
You can also share your feedback on Copilot code review. Take the survey.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataTask.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement GetLastExceptionState on the managed ClrDataTask (IXCLRDataTask). Reads LastThrownObjectHandle from the Thread contract, constructs a ClrDataExceptionState with CLRDATA_EXCEPTION_PARTIAL and no nested exception chain, following the same pattern as GetCurrentExceptionState.
Test Results
6 new unit tests pass covering no-exception, with-exception, and nested-exception-not-propagated scenarios, with no regressions.