Investigate regex lazy quantifier with optional group regression in .NET 10#125330
Draft
Investigate regex lazy quantifier with optional group regression in .NET 10#125330
Conversation
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Copilot
AI
changed the title
[WIP] Fix regex lazy quantifier issue in .NET 10
Investigate regex lazy quantifier with optional group regression in .NET 10
Mar 9, 2026
Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
Copilot stopped work on behalf of
stephentoub due to an error
March 9, 2026 15:07
Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
Copilot stopped work on behalf of
stephentoub due to an error
March 10, 2026 21:12
This was referenced Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Status: Investigation only — no fix implemented yet.
Regex pattern
a(b.*?c)?dfails to matchabccdin .NET 10, a regression from .NET 9. The bug occurs when a lazy quantifier (*?) with min=0 usingSetlazy/Notonelazy(character class or negated-char loops) is inside an optional group(...)?.Investigation findings
Setlazy/Notonelazywith M=0 inside optional groups fail;Onelazywith M=0 works; M≥1 worksSetjump/Forejump(atomic group markers) wrapping the outer?loop, preventing backtracking into the inner.*?FindAndMakeLoopsAtomicinRegexNode.cs, introduced by commitc0f4c7dd39("Support auto-atomicity on {lazy} loops", Support auto-atomicity on {lazy} loops #117943).CanBeMadeAtomicfor generalLoopnodes checks only the loop body's first/last character classes against the subsequent node, but doesn't account for characters matchable by internal lazy quantifiers. TheMayContainBacktrackingguard (Fix incorrect atomic loop optimization when body contains backtracking #124254) should block this but the atomic wrapper still appears in bytecodes through a path not yet identified.What remains
MayContainBacktrackingreturning trueRegex.Match.Tests.cs🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.