Skip to content

[Wasm RyuJIT] Fix classifier embiggening small structs that are being passed-as a wasm primitive#125278

Merged
kg merged 3 commits intodotnet:mainfrom
kg:issue125199-1
Mar 9, 2026
Merged

[Wasm RyuJIT] Fix classifier embiggening small structs that are being passed-as a wasm primitive#125278
kg merged 3 commits intodotnet:mainfrom
kg:issue125199-1

Conversation

@kg
Copy link
Copy Markdown
Member

@kg kg commented Mar 6, 2026

Addresses part of #125199

@kg kg added arch-wasm WebAssembly architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Mar 6, 2026
Copilot AI review requested due to automatic review settings March 6, 2026 20:30
@kg kg changed the title Fix classifier embiggening small structs that are being passed-as a wasm primitive [Wasm RyuJIT] Fix classifier embiggening small structs that are being passed-as a wasm primitive Mar 6, 2026
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts Wasm ABI classification for small structs that are lowered to Wasm primitive types to avoid size/type mismatches during local stack stores (part of #125199).

Changes:

  • Compute the ABI passing segment size for lowered structs using the struct’s actual size (capped by the ABI primitive size) instead of always using the primitive size.

@kg kg marked this pull request as ready for review March 7, 2026 00:26
Copilot AI review requested due to automatic review settings March 7, 2026 00:26
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

@kg
Copy link
Copy Markdown
Member Author

kg commented Mar 9, 2026

cc @dotnet/jit-contrib

@kg kg merged commit 8d8e749 into dotnet:main Mar 9, 2026
132 of 135 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants