Skip to content

Fix bounds checks in #123085 repro#125235

Merged
EgorBo merged 3 commits intodotnet:mainfrom
EgorBo:fix-miha-bc-repro
Mar 6, 2026
Merged

Fix bounds checks in #123085 repro#125235
EgorBo merged 3 commits intodotnet:mainfrom
EgorBo:fix-miha-bc-repro

Conversation

@EgorBo
Copy link
Member

@EgorBo EgorBo commented Mar 5, 2026 •
edited
Loading

Closes #123085

Diffs

given (X + negativeConst) u< Y for int32 vars
where u< is unsigned less than
Y is a proven never negative bound
negativeConst is a negative constant (> INT32_MIN)

We deduce X >= -negativeConst

Copilot AI review requested due to automatic review settings March 5, 2026 19:50
Copilot AI reviewed Mar 5, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 5, 2026
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Mar 5, 2026

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@EgorBo EgorBo marked this pull request as ready for review March 5, 2026 20:15
Copilot AI review requested due to automatic review settings March 5, 2026 20:15
Copilot AI reviewed Mar 5, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

@EgorBo EgorBo requested a review from Copilot March 5, 2026 22:45
Copilot AI reviewed Mar 5, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

This was referenced Mar 6, 2026
Open
Open
Open
@EgorBo EgorBo requested a review from jakobbotsch March 6, 2026 12:17
@EgorBo
Copy link
Member Author

EgorBo commented Mar 6, 2026

PTAL @jakobbotsch @dotnet/jit-contrib

@EgorBo EgorBo merged commit d0118d9 into dotnet:main Mar 6, 2026
143 of 147 checks passed
@EgorBo EgorBo deleted the fix-miha-bc-repro branch March 6, 2026 13:06
@dotnet-maestro dotnet-maestro bot mentioned this pull request Mar 7, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees

@EgorBo EgorBo

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bound check with uint casts no longer elided

3 participants

@EgorBo @jakobbotsch