Support InstructionSet_VectorT in HWIntrinsic importer#125226

Merged

dhartglassMSFT merged 10 commits intodotnet:mainfrom

snickolls-arm:import-vectort-isa

Apr 8, 2026

Contributor

snickolls-arm commented Mar 5, 2026 •

edited

Loading

Add an empty intrinsic table for SVE-backed Vector<T> and implement some of the plumbing required to recognize these intrinsics on import.


          Support InstructionSet_VectorT in HWIntrinsic importer

a6a9e6f

Add an empty intrinsic table for SVE-backed Vector<T> and implement
some of the plumbing required to recognize these intrinsics on import.

github-actions bot added the area-CodeGen-coreclr label

dotnet-policy-service bot added the community-contribution label


          Add missing debug ifdefs

1e45b9b

jkotas added the arm-sve label

This was referenced Mar 5, 2026

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

[android][arm64] System.Net.Sockets.Tests.SendTo_SyncForceNonBlocking.Datagram_UDP_ShouldImplicitlyBindLocalEndpoint fails with NetworkUnreachable #120526

Open

[android-arm64] The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#6408

Open

snickolls-arm mentioned this pull request

Accelerating Vector<T> with SVE on ARM64 #120599

Open

10 tasks

Contributor Author

snickolls-arm commented Mar 16, 2026

@dotnet/arm64-contrib Please could I have a review on this patch?

tannergooding reviewed

View reviewed changes

src/coreclr/jit/compiler.h Outdated Show resolved Hide resolved

tannergooding reviewed

View reviewed changes

src/coreclr/jit/hwintrinsic.h Outdated Show resolved Hide resolved

tannergooding reviewed

View reviewed changes

src/coreclr/jit/hwintrinsicarm64.cpp Outdated Show resolved Hide resolved

tannergooding reviewed

View reviewed changes

src/coreclr/jit/importercalls.cpp Outdated Show resolved Hide resolved

tannergooding reviewed

View reviewed changes

src/coreclr/jit/importercalls.cpp Outdated Show resolved Hide resolved

tannergooding reviewed

View reviewed changes

src/coreclr/jit/importercalls.cpp Outdated Show resolved Hide resolved

snickolls-arm and others added 3 commits

March 17, 2026 11:16


          Address review comments

36b635e

* Use compExactlyDependsOn
* Improve Vector class name string matching
* Remove unused sizes from assertion
* Do not change Vector class name
* Revert change to tryLookupSimdSize


          Fix off-by-ones in string matching

5ef5e97


          Merge branch 'main' into import-vectort-isa

dd64a39

tannergooding approved these changes

View reviewed changes

tannergooding requested a review from dhartglassMSFT

March 17, 2026 16:49

This was referenced Mar 17, 2026

XHarness package install failure on iOS due to devicectl NSPOSIXErrorDomain error 49 #123796

Open

MsQuic fails with QUIC_STATUS_OUT_OF_MEMORY on AzureLinux #123216

Open

Crst Level violation: Can't take level 17 lock CrstLoaderAllocatorReferences #125638

Closed

Copilot AI mentioned this pull request

Partially revert #125574: restore fixed buffers in networking P/Invoke structs to fix Crst level violation #125664

Closed

dhartglassMSFT reviewed

View reviewed changes

src/coreclr/jit/hwintrinsic.h Outdated Show resolved Hide resolved

dhartglassMSFT reviewed

View reviewed changes

src/coreclr/jit/compiler.h Show resolved Hide resolved

dhartglassMSFT reviewed

View reviewed changes

src/coreclr/jit/hwintrinsicarm64.cpp Show resolved Hide resolved

snickolls-arm and others added 2 commits

March 25, 2026 14:41


          Remove blank line

60713cd


          Merge branch 'main' into import-vectort-isa

05eace1


          Merge branch 'main' into import-vectort-isa

1192a0c

Contributor Author

snickolls-arm commented Mar 30, 2026

@dhartglassMSFT are you happy with my responses to the review comments? Let me know if anything else is required for merge

Contributor Author

snickolls-arm commented Mar 30, 2026

Formatting errors have appeared on a few of my PRs after merging with main, are there formatting issues on main at the moment?

Member

jakobbotsch commented Mar 30, 2026

Formatting errors have appeared on a few of my PRs after merging with main, are there formatting issues on main at the moment?

Yes, but a fix was merged already: #126296


          Merge branch 'main' into import-vectort-isa

b800064

dhartglassMSFT enabled auto-merge (squash)

April 8, 2026 07:14


          Merge branch 'main' into import-vectort-isa

b7f26f4

Contributor

dhartglassMSFT commented Apr 8, 2026

@dhartglassMSFT are you happy with my responses to the review comments? Let me know if anything else is required for merge

Yeah - sorry, I missed the "@". I'll merge the change after the latest round of testing completes

Contributor

dhartglassMSFT commented Apr 8, 2026

Linux x64 tests are failures in "NameResolution*" that has a bug elsewhere.
Spot checked the wasm failures, they aren't different from what is seen on other runs

Contributor

dhartglassMSFT commented Apr 8, 2026

/ba-g known unrelated failures

dhartglassMSFT merged commit 2148709 into dotnet:main

132 of 137 checks passed

dotnet-maestro bot mentioned this pull request

[main] Source code updates from dotnet/runtime dotnet/dotnet#5943

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-CodeGen-coreclr arm-sve community-contribution