Mark SampleProfilerSampleType.TestEntryPoint with [ActiveIssue] for Native AOT#125218
Merged
MichalStrehovsky merged 2 commits intomainfrom Mar 5, 2026
Merged
Conversation
…ative AOT (#125217) Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Mark TestEntryPoint with ActiveIssue attribute for Native AOT
Mark SampleProfilerSampleType.TestEntryPoint with [ActiveIssue] for Native AOT
Mar 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the EventPipe tracing test SampleProfilerSampleType.TestEntryPoint to be skipped on Native AOT runs via an [ActiveIssue] attribute, aligning it with existing dotnet/runtime test patterns while the tracked issue remains unresolved.
Changes:
- Add
using TestLibrary;so the test can referenceUtilities.IsNativeAot. - Mark
TestEntryPointwith[ActiveIssue(..., typeof(Utilities), nameof(Utilities.IsNativeAot))]to skip on Native AOT.
You can also share your feedback on Copilot code review. Take the survey.
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
3 tasks
Member
|
Also cc @dotnet/ilc-contrib. Outerloops are all red again and this is making it hard to spot real issues in the runs. |
jkotas
approved these changes
Mar 5, 2026
agocke
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SampleProfilerSampleType.TestEntryPoint(added in #124410) fails on Native AOT. Skipping it there until #125217 is resolved.Description
[ActiveIssue("https://github.com/dotnet/runtime/issues/125217", typeof(Utilities), nameof(Utilities.IsNativeAot))]above[Fact]onTestEntryPointusing TestLibrary;(needed forUtilities.IsNativeAot)Pattern matches existing usage in
rundownvalidation.cs.Original prompt
Problem
The test
SampleProfilerSampleType.TestEntryPointadded in PR #124410 (src/tests/tracing/eventpipe/eventsvalidation/SampleProfilerSampleType.cs) is failing in Native AOT runs. It needs to be marked with an[ActiveIssue]attribute scoped to Native AOT until the issue is resolved.Tracking issue: #125217
Required Change
In
src/tests/tracing/eventpipe/eventsvalidation/SampleProfilerSampleType.cs, add the following[ActiveIssue]attribute to theTestEntryPointmethod, directly above the existing[Fact]attribute:The result should look like:
Additionally, add a
using TestLibrary;directive to the using statements at the top of the file (needed forUtilities.IsNativeAot), sinceUtilitiescomes fromTestLibrary. Look at nearby tests likesrc/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.csto confirm the pattern — it already hasusing TestLibrary;and uses[ActiveIssue("...", typeof(Utilities), nameof(Utilities.IsNativeAot))].The current file is at:
src/tests/tracing/eventpipe/eventsvalidation/SampleProfilerSampleType.cscf47e8c1c9fc80228157af41d54184e99fc010afCurrent file content for reference