Merged
Conversation
Contributor
Author
|
@sbomer please take a look |
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/illink |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores the virtual modifier on the MarkAssembly method in MarkStep.cs, which was inadvertently removed in PR #120477 (Update TypeMap attribute handling). Unity depends on overriding this method in their linker customizations.
Changes:
- Adds back the
virtualkeyword toMarkAssembly(AssemblyDefinition, DependencyInfo, MessageOrigin)inMarkStep.cs
sbomer
approved these changes
Mar 4, 2026
Contributor
Author
|
@sbomer I don't think the CI failures are related. Ready to merge. |
This was referenced Mar 5, 2026
Member
|
/ba-g "Test passed but results were not reported due to APP_CRASH" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#120477 removed the virtual on
MarkAssembly. Unity needs to override this method. Adding back thevirtual