Disable ProxySetViaEnvironmentVariable_DefaultProxyCredentialsUsed on macOS#125170
Disable ProxySetViaEnvironmentVariable_DefaultProxyCredentialsUsed on macOS#125170rzikm merged 2 commits intodotnet:release/8.0-stagingfrom
Conversation
… macOS The test crashes with SIGABRT (exit code 134) on macOS 14 due to a double-free bug in Apple's GSS framework (_gss_scram_release_cred) when cleaning up SPNEGO/Negotiate authentication contexts. This is a known macOS bug (not a .NET bug) that affects .NET 8 which uses the native GSS APIs. .NET 9+ is unaffected because it uses a managed NTLM/SPNEGO implementation. Fix dotnet#125150 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Skips ProxySetViaEnvironmentVariable_DefaultProxyCredentialsUsed on macOS to avoid a SIGABRT crash in System.Net.Http.Functional.Tests caused by an Apple GSS double-free (tracked by #125150).
Changes:
- Add an OSX-specific skip attribute to the affected proxy/default-credentials test.
You can also share your feedback on Copilot code review. Take the survey.
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.DefaultProxyCredentials.cs
Outdated
Show resolved
Hide resolved
…st.DefaultProxyCredentials.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
You can also share your feedback on Copilot code review. Take the survey.
|
Test-only change => tell mode |
|
we should use the managed implementation - If the tests don't we should update them. |
we switched to managed impl. in .NET 9, is it available on OSX on 8.0? Even if yes, I am not sure if testing non-default implementation gives us much. |
|
ah, I missed fact this is for 8.0 since it did not have it in the title. I'm fine disabling the test in 8. |
Fixes #125150
main PR: N/A — this is a test-only change specific to .NET 8 (the underlying macOS GSS bug doesn't affect .NET 9+ which uses managed NTLM/SPNEGO).
Description
Skip the
ProxySetViaEnvironmentVariable_DefaultProxyCredentialsUsedtest on macOS. The test crashes with SIGABRT (exit code 134) on macOS 14 due to a double-free bug in Apple's GSS framework (_gss_scram_release_cred) when cleaning up SPNEGO/Negotiate authentication contexts viaNetSecurityNative_DeleteSecContext. This is the same underlying issue as #97966 and #71463.Customer Impact
None. This is a test-only change — no product code is modified.
Regression
No. The crash is caused by a bug in Apple's macOS GSS framework, not by a .NET code change. It started appearing in CI after the macOS build images were updated (PR #122423), and has been failing since build 1252235 (Jan 13, 2026).
Testing
No additional testing needed. The change only adds a
[SkipOnPlatform]attribute to skip one test on macOS.Risk
Low. This is a single-line test attribute addition that skips a test known to crash due to an external (Apple) bug. No product code is changed.
Package authoring signed off?
N/A — no package/product code changes.