Merged
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds initial support for the Arm64 SVE2 Match / NoMatch intrinsics (and corresponding tests) to the runtime/JIT and the HWIntrinsic test generator.
Changes:
- Introduces new SVE2 intrinsics
MatchandNoMatchfor byte/sbyte/short/ushort. - Extends SVE2 test generation to cover the new intrinsics.
- Adds managed test helper implementations for expected results.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/JIT/HardwareIntrinsics/Arm/Shared/Helpers.cs | Adds Match/NoMatch helper logic for expected-value computation (but this file is generated). |
| src/tests/Common/GenerateHWIntrinsicTests/Arm/Sve2Tests.cs | Adds generator entries to produce tests for Match/NoMatch. |
| src/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs | Adds the public ref declarations for Match/NoMatch. |
| src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve2.cs | Adds the SVE2 API surface for Match/NoMatch. |
| src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve2.PlatformNotSupported.cs | Adds PNSE stubs for Match/NoMatch when SVE2 isn’t supported. |
| src/coreclr/jit/hwintrinsiclistarm64sve.h | Registers the new SVE2 intrinsics with the JIT intrinsic table. |
This was referenced Mar 4, 2026
jakobbotsch
approved these changes
Mar 5, 2026
Member
jakobbotsch
left a comment
There was a problem hiding this comment.
LGTM, would wait for @a74nh's review and possibly @tannergooding's as well
a74nh
reviewed
Mar 5, 2026
a74nh
approved these changes
Mar 6, 2026
tannergooding
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially contributes to #94021