[Wasm RyuJIT] Call signatures by kg · Pull Request #125153 · dotnet/runtime

kg · 2026-03-03T23:12:32Z

This gets us generating valid modules for my set of test scenarios by generating correct call signatures.

EDIT: With this PR, the generated code for i.e. a gc write barrier helper call looks like:

@1075  2004           ..get_local 4 ; i32 local0
@1077  4100           ..i32_const 0
@1079  6A             ..i32_add
@1080  2005           ..get_local 5 ; i32 local1
@1082  4100           ..i32_const 0
@1084  6A             ..i32_add
@1085  2301           ..get_global 1 ; i32 env.__r2r_start
@1087  41B8818802     ..i32_const 0x004200B8 ; 4325560
@1092  6A             ..i32_add
@1093  280000         ..i32_load +0
@1096  11818080800000 ..call_indirect 1 tables[0] ; v(ii)

Note that we're missing support for address relocations in crossgen so I just emit the raw truncated helper address value as a displacement against __r2r_start.

dotnet-policy-service · 2026-03-03T23:13:28Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates the WASM RyuJIT emitter to provide real call-indirect signatures by deriving argument lowering from method handles and by hard-coding signatures for certain runtime helpers, then passing those signatures to the JIT↔EE getWasmTypeSymbol API.

Changes:

Build a CorInfoWasmType signature array for emitIns_Call when params.methHnd is available.
Special-case a set of helper calls (detected via eeGetHelperNum) with hard-coded signatures.
Use the computed signature to obtain a CORINFO_WASM_TYPE_SYMBOL_HANDLE for call_indirect.

src/coreclr/jit/emitwasm.cpp

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

src/coreclr/jit/codegenwasm.cpp

src/coreclr/jit/lower.cpp

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

src/coreclr/jit/codegenwasm.cpp

kg · 2026-03-05T21:41:16Z

Found an oversight, working on it.
EDIT: Addressed it

kg · 2026-03-05T22:19:30Z

@dotnet/jit-contrib I think this is ready for review now and gets us generating valid modules for all the cases I've tested. It also gets us closer to generating the right code.

SingleAccretion

LGTM modulo comments.

src/coreclr/jit/codegenwasm.cpp

src/coreclr/jit/lower.cpp

src/coreclr/jit/emitwasm.cpp

src/coreclr/jit/codegenwasm.cpp

src/coreclr/jit/lower.cpp

src/coreclr/jit/codegenwasm.cpp

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

src/coreclr/jit/codegenwasm.cpp

src/coreclr/jit/emitwasm.cpp

src/coreclr/jit/codegenwasm.cpp

adamperlin

This looks good to me, just two questions!

Copilot AI review requested due to automatic review settings March 3, 2026 23:12

kg added arch-wasm WebAssembly architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Mar 3, 2026

dotnet-policy-service bot assigned kg Mar 3, 2026

Copilot started reviewing on behalf of kg March 3, 2026 23:13 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

src/coreclr/jit/emitwasm.cpp Outdated Show resolved Hide resolved

src/coreclr/jit/emitwasm.cpp Outdated Show resolved Hide resolved

src/coreclr/jit/emitwasm.cpp Outdated Show resolved Hide resolved

build-analysis bot mentioned this pull request Mar 4, 2026

[android][clr] No peer certificates when executing System.Net.Http.Functional.Tests on Android emulator #124526

Open

SingleAccretion reviewed Mar 4, 2026

View reviewed changes

src/coreclr/jit/emitwasm.cpp Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings March 4, 2026 22:12

Copilot started reviewing on behalf of kg March 4, 2026 22:13 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

kg added 6 commits March 5, 2026 11:25

Checkpoint call signatures

ad5370d

Checkpoint

8c2de66

Formatting

d0b0111

Checkpoint

5ea7e13

Fix lowering ifdef

6b45e27

This reloc is incorrect and doesn't work right now

89ec13b

kg force-pushed the wasm-callsigs-1 branch from 849e123 to 89ec13b Compare March 5, 2026 20:48

Address copilot feedback

b076bda

Copilot AI review requested due to automatic review settings March 5, 2026 20:53

kg marked this pull request as ready for review March 5, 2026 20:54

Copilot started reviewing on behalf of kg March 5, 2026 20:55 View session

Copilot AI reviewed Mar 5, 2026

View reviewed changes

src/coreclr/jit/codegenwasm.cpp Outdated Show resolved Hide resolved

src/coreclr/jit/codegenwasm.cpp Show resolved Hide resolved

kg added 2 commits March 5, 2026 13:24

jit-format, correct oversight in signatures table

a17be76

Comments

837394e

Checkpoint

8ba0d05

SingleAccretion reviewed Mar 6, 2026

View reviewed changes

kg added 3 commits March 6, 2026 07:41

Address PR feedback

c061545

Address PR feedback

02771a6

jit-format

115bd32

Copilot AI review requested due to automatic review settings March 6, 2026 15:56

Copilot started reviewing on behalf of kg March 6, 2026 15:58 View session

AndyAyersMS reviewed Mar 6, 2026

View reviewed changes

src/coreclr/jit/lower.cpp Outdated Show resolved Hide resolved

src/coreclr/jit/lower.cpp Show resolved Hide resolved

src/coreclr/jit/codegenwasm.cpp Outdated Show resolved Hide resolved

Copilot AI reviewed Mar 6, 2026

View reviewed changes

src/coreclr/jit/codegenwasm.cpp Outdated Show resolved Hide resolved

AndyAyersMS mentioned this pull request Mar 6, 2026

[Wasm RyuJit] Wasm signatures for helper calls #124978

Open

Tweak and fix error in printf format

20ef88e

jkotas reviewed Mar 6, 2026

View reviewed changes

src/coreclr/jit/codegenwasm.cpp Show resolved Hide resolved

SingleAccretion approved these changes Mar 9, 2026

View reviewed changes

src/coreclr/jit/codegenwasm.cpp Show resolved Hide resolved

adamperlin reviewed Mar 9, 2026

View reviewed changes

src/coreclr/jit/emitwasm.cpp Show resolved Hide resolved

adamperlin reviewed Mar 9, 2026

View reviewed changes

src/coreclr/jit/codegenwasm.cpp Show resolved Hide resolved

adamperlin reviewed Mar 9, 2026

View reviewed changes

src/coreclr/jit/codegenwasm.cpp Show resolved Hide resolved

adamperlin approved these changes Mar 9, 2026

View reviewed changes

AndyAyersMS approved these changes Mar 9, 2026

View reviewed changes

kg merged commit d19b7ca into dotnet:main Mar 9, 2026
131 checks passed

dotnet-maestro bot mentioned this pull request Mar 10, 2026

[main] Source code updates from dotnet/runtime dotnet/dotnet#5345

Merged

Conversation

kg commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-service bot commented Mar 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

kg commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kg commented Mar 5, 2026

Uh oh!

SingleAccretion left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adamperlin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

kg commented Mar 3, 2026 •

edited

Loading

kg commented Mar 5, 2026 •

edited

Loading